Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Marketplace] Don't trust a passed in shop #400

Closed
queso opened this issue Jul 1, 2015 · 2 comments
Closed

[Marketplace] Don't trust a passed in shop #400

queso opened this issue Jul 1, 2015 · 2 comments

Comments

@queso
Copy link
Contributor

queso commented Jul 1, 2015

We are passing in a shop to the packages pub. https://github.com/reactioncommerce/reaction-core/blob/development/server/publications.coffee#L89

certainly make no sense as is, should as least be ` shop = shop || ReactionCore.getCurrentShop(@)`.    I think this is more a hint of the functionality needed for the marketplace(multi-shop)..  which might publications might need a shop param (or something like this https://github.com/DispatchMe/Meteor-restricted-find)
@queso
Copy link
Contributor Author

queso commented Jul 1, 2015

@aaronjudd can you explain the concept of a multi-shop more? Is this something supported now, or planned for in the future?

@aaronjudd
Copy link
Contributor

yes, see #357.

We've begun implementing parts of this. and there are other community members developing there own versions of this, and I feel like we should try at least add to the schema/model/publications handling, even if we don't build any UI for this right now.

@aaronjudd aaronjudd added this to the Core Architecture milestone Jul 22, 2015
@aaronjudd aaronjudd added backlog and removed ready labels Jan 13, 2016
@aaronjudd aaronjudd added the core label Sep 9, 2016
@aaronjudd aaronjudd modified the milestone: Core Architecture Sep 9, 2016
@spencern spencern changed the title Don't trust a passed in shop [Marketplace] Don't trust a passed in shop Apr 11, 2017
@ghost ghost removed the backlog label Apr 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants