Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] in "product edit" functionality #498

Closed
newsiberian opened this issue Oct 23, 2015 · 14 comments
Closed

[Feature] in "product edit" functionality #498

newsiberian opened this issue Oct 23, 2015 · 14 comments
Assignees

Comments

@newsiberian
Copy link
Contributor

Hello. I believe, you already have this feature in plans, but what do you think about "product edit" functionality expansion by allowing a massive (group):

  • item size changing;
  • publishing, duplicating and deleting;

Visually this can be done by adding something like "+" button to gridControls, which can select an item or maybe this can be done by other way.

@aaronjudd
Copy link
Contributor

Is this the feature you are referring to? Product Inheritance Management #150

@newsiberian
Copy link
Contributor Author

Hello, no this is not pretty similar. This feature is based on our experience. The people who manage content, they want the things should be easy. Imagine that you just select several products on your screen by clicking "+" button, or by ctrl + click on these products and one thing you want to do is change their size or delete them massively. It must be easy to do quickly.

@aaronjudd
Copy link
Contributor

I think you're talking about UX here, not functionality then? Perhaps you'd like some to provide some sketches? We've had quite a few discussions on how to make this a simple UI, but would love to hear some more ideas. #150 is describing complex behaviour, but our goal is always to make it as simple as possible from an admin UI perspective. We too have a lot of experience both as developers but as operators of stores with large catalogs, so the admin experience has always been important to us - in fact I personally believe it needs to be the most important UIX experience.

@newsiberian
Copy link
Contributor Author

if I understood correct you are talking about illustration of my idea? Here is an explanation. Idea was taken from file manager:
screencast-products-moving

It would be great, if we could take this selection feature to our grid, with the following visually changes:

reaction_screen_1_mod

@mikemurray
Copy link
Member

@newsiberian makes sense.

Changes that would need to be made for the product grid

  • Make product grid items bulk selectable
  • Side panel should always accept 1 or more products for management

This is fine for just managing multiple products as they appear in the grid that share similar attributes. Like changing their size, or hiding / deleting.

@aaronjudd aaronjudd added this to the Product Management milestone Oct 28, 2015
@mikemurray mikemurray self-assigned this Oct 30, 2015
@mikemurray
Copy link
Member

Added the ability to select multiple products using (shift + click). This will allow you to mass toggle visibility, delete, clone and change size.

This feature is not yet complete, but has been rolled into development so everyone can test and give feedback. You can test it out if you clone reaction-core and reaction-core-theme development branches.

In addition pagination has been added as well from #303.

@mikemurray
Copy link
Member

Preview:
screen shot 2015-10-30 at 3 41 55 pm

@newsiberian
Copy link
Contributor Author

Hello, @mikemurray, thanks for fast implementation. Looks good. Now it's far more native, I think.

@ramusus
Copy link
Contributor

ramusus commented Jan 7, 2016

Good feature! Thanks for implementation!

But I found one problem: after group hide/show or change size - right panel becomes inactive for the next actions. It make behaviour unfriendly and force to select products again:

http://cl.ly/373B3b1B3c01

@aaronjudd
Copy link
Contributor

@ramusus yes, I noticed this as well, this might be a regression in the current release. I didn't think it was doing this before.

@aaronjudd
Copy link
Contributor

@newsiberian @mikemurray this probably should have been closed already? (but now has a bug)

@newsiberian
Copy link
Contributor Author

If you asking to me, I think we still could add some features here. I strongly believe there is not enough a functionality which will be unselect all selected items if user clicks on a free space around items in grid or press the button esc.

@ramusus
Copy link
Contributor

ramusus commented Jan 31, 2016

@newsiberian, @mikemurray I think we should accomplish selecting behaviour:

  • "cmd (ctrl?) + click" selects one more product (like now shift does)
  • "shift + click" selects all products between clicked and already selected

What do you think? I can do PR

@mikemurray
Copy link
Member

I believe this issue to been resolved a while ago. Closing for now. If there are more features please open a new ticket.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants