-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate permissions against ticket #372 #797
Comments
from @newsiberian
First glance, packages.enabled is not needed here.. |
@zenweasel It appears I am blocked by #799. I am unable to create a second shop, and successfully navigate to that second shop. I was made aware of 'Meteor.call("shop/createShop")' which would potentially force a second shop creation. However, doing so would not be a valid test case. |
@Capt-Slow How are you blocked from writing tests for this because this UI doesn't support it? |
@zenweasel It doesn't appear that I am able to successfully create a second shop (even though there is data placeholders in Mongo). I attempted to create a second shop by renaming '<blank_site>' in the DB. Now if I force a second shop creation using the Meteor.call, I was told it's kind of a hack. So it appears the feature of multi-shops isn't complete. The integration tests I write in which case should fail. From my limited understanding, CI builds would also fail? |
Ok, can we create a ticket or a test-plan for what tests for a complete implementation of multi-shops would look like? Starting with being able to programmatically create a shop I would think. |
Closing in favor of #2075 |
This ticket lays out how permissions should work for multi-shop so we need to double-check these have not changed.
The text was updated successfully, but these errors were encountered: