Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate permissions against ticket #372 #797

Closed
brent-hoover opened this issue Feb 19, 2016 · 6 comments
Closed

Validate permissions against ticket #372 #797

brent-hoover opened this issue Feb 19, 2016 · 6 comments
Milestone

Comments

@brent-hoover
Copy link
Collaborator

brent-hoover commented Feb 19, 2016

This ticket lays out how permissions should work for multi-shop so we need to double-check these have not changed.

@aaronjudd aaronjudd added this to the v0.12.0 milestone Feb 19, 2016
@brent-hoover brent-hoover self-assigned this Feb 19, 2016
@aaronjudd
Copy link
Contributor

from @newsiberian

Hello, could you please check "core" permissions. Looks like they missing inside accounts "Edit member" settings. Thats because of they failed on if (pkg.registry && pkg.enabled) { check here

First glance, packages.enabled is not needed here..

@aaronjudd aaronjudd modified the milestones: v0.13.0, v0.12.0 Mar 20, 2016
@brent-hoover brent-hoover modified the milestones: v0.14.0, v0.13.0 May 17, 2016
@aaronjudd aaronjudd modified the milestones: v0.15.0 RC, v0.14.0 Jun 28, 2016
@Capt-Slow
Copy link
Contributor

@zenweasel It appears I am blocked by #799. I am unable to create a second shop, and successfully navigate to that second shop. I was made aware of 'Meteor.call("shop/createShop")' which would potentially force a second shop creation. However, doing so would not be a valid test case.

@brent-hoover
Copy link
Collaborator Author

@Capt-Slow How are you blocked from writing tests for this because this UI doesn't support it?

@Capt-Slow
Copy link
Contributor

Capt-Slow commented Jul 27, 2016

@zenweasel It doesn't appear that I am able to successfully create a second shop (even though there is data placeholders in Mongo). I attempted to create a second shop by renaming '<blank_site>' in the DB. Now if I force a second shop creation using the Meteor.call, I was told it's kind of a hack. So it appears the feature of multi-shops isn't complete. The integration tests I write in which case should fail. From my limited understanding, CI builds would also fail?

@brent-hoover
Copy link
Collaborator Author

Ok, can we create a ticket or a test-plan for what tests for a complete implementation of multi-shops would look like? Starting with being able to programmatically create a shop I would think.

@brent-hoover
Copy link
Collaborator Author

Closing in favor of #2075

@ghost ghost removed the ready label Apr 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants