Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative implementation approach #1

Open
gasche opened this issue Oct 15, 2017 · 1 comment
Open

Alternative implementation approach #1

gasche opened this issue Oct 15, 2017 · 1 comment

Comments

@gasche
Copy link

gasche commented Oct 15, 2017

You shouldn't need to fork the whole codebase, because ocamlbuild provides ocamlbuild_pack.cmo that contains all the modules and the logic. So you should be able to just write your rmlbuild_specific.ml file (opening Ocamlbuild_pack in front), then fork the main.ml file, and then write a tiny rmlbuild.ml that just call the main () function, like ocamlbuild.ml does:

open Ocamlbuild_pack
Ocamlbuild_unix_plugin.setup ();
Rml_main.main ()

I think that doing this would minimize synchronization woes for you if the ocamlbuild sources evolve.

@mandel
Copy link
Member

mandel commented Oct 16, 2017

You are right, we should try to reimplement rmlbuild as you suggest. This code was simply an update of the old rmlbuild adapted to the new implementation of ocamlbuild.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants