-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs]: Rename/Aliasing the combineAll operator to combineLatestAll #4590
Comments
|
As far as I know, there is no Let me reference the docs to give a more tangible input why I believe the renaming makes sense: |
Yes, there isn't combine operator. My q is if combineAll goes combineLatestAll, it'll not be aligned with existing combineLatest operator. I am not necessarily agreed your argument: internally it calls combineLatest yes, but it's special kind of projection and not transparent forwarding to combineLatest. Also worth note we are trying to reduce alias at all cost, not expanding it. We have observed amount of confusion by one operator have different names and do not want to bring additional. |
Thanks for further elaboration @kwonoj I appreciate that you take you time! Here is a overview that shows the foundation for my suggestion of renaming It's a naming matrix for operators. Regarding aliases:
I would suggest a renaming in version 7 as there are anyway breaking changes. In my opinion consistency in naming is most important to learn all the different operators. I have even more suggestions that would fix inconsistencies in naming and would help people to learn. If there is Interest cc @benlesh @cartant @jwo719 I can try to deliver a fully fledged suggestion for consistent naming of all operators in the next 2-3 weeks. As I said, creating a naming matrix and have consistent naming would help the community a lot in learning. |
Another reason why renaming/aliasing should be doable: |
From core team meeting: We should alias |
Current Behavior
All good! Just the naming might be confusing.
Possible Solution
I would expect the name of combineAll to be combineLatestAll.
Additional context/Screenshots
If you take a look to the "naming convention" you will realize that all the other operators like switchAll, mergeAll, zipAll etc. process higher order observables and follow the patterns [operatorName]All.
Therefore I consider the naming as inconsistent. For me it implies a different behavior.
I would suggest to implement it as an alias.
The text was updated successfully, but these errors were encountered: