Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: predicates that return any will now behave property with findIndex #6097

Merged

Conversation

cartant
Copy link
Collaborator

@cartant cartant commented Mar 7, 2021

Description:

The changes in #5987 missed a findIndex signature that matched predicates that always returned false and was not compatible with predicates typed as returning any.

Related issue (if exists): #5986 and #5987

@cartant cartant requested a review from benlesh March 7, 2021 07:37
@benlesh
Copy link
Member

benlesh commented Mar 8, 2021

😭 this one was my fault. Fortunately it only lived during the beta.

@benlesh benlesh merged commit c6f73d6 into ReactiveX:master Mar 8, 2021
@cartant cartant deleted the cartant/find-index-false-signature branch March 19, 2021 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants