feat(onErrorResumeNextWith): renamed `onErrorResumeNext` and exported from the top level #6755

benlesh · 2022-01-11T21:48:50Z

The onErrorResumeNext operator is deprecated due to a rename. The rename was done so we can move all operator exports to the top level rxjs export site. We were not currently exporting that operator.

This commit also refactors to logic to be based on the creation function, which is more widely used

benlesh · 2022-01-11T21:49:43Z

This one is just one we missed. I don't like the late deprecation, but I somehow doubt the operator version of this is in wide use.

jakovljevic-mladen · 2022-01-12T11:46:11Z

importing.md file should be updated as well.

jakovljevic-mladen

I think some things are not aligned with other similar changes, for example in combineLatest/combineLatestWith or concat/concatWith...

jakovljevic-mladen · 2022-01-14T19:35:50Z

src/internal/operators/onErrorResumeNextWith.ts

+/**
+ * @deprecated Renamed. Use {@link onErrorResumeNextWith} instead. Will be removed in v8.
+ */
+export const onErrorResumeNext = onErrorResumeNextWith;


Shouldn't onErrorResumeNext stay in this file (onErrorResumeNext.ts) and onErrorResumeNextWith get exported from another file (onErrorResumeNextWith.ts)? This is what's done with combineLatest, concat and others...

I'm indifferent about that. That's all internal implementation and has no bearing on users.

I think we may have issues with the docs builder, though I'm not completely sure. Let me check it.

I can't really make the docs work properly. The code changes from this PR seem to create multiple issues.

One of the issues that this function has is described in #7009.

The other is this:

The dgeni didn't properly infer the type. The inferred type seems to be: { <T, A extends any, unknown>(): any; <T, A extends any, unknown>(): any; <T, A extends any, unknown>(): any; }; which doesn't really mean anything.

I will try to dig deeper into the issue tomorrow.

It looks like other constants are having the same issue. E.g. flatMap:

So, I don't think this is something we can do about by moving to another file, which would be OK only for consistency reasons, nothing else.

jakovljevic-mladen · 2022-01-14T19:36:48Z

src/operators/index.ts

@@ -57,7 +57,7 @@ export { mergeWith } from '../internal/operators/mergeWith';
 export { min } from '../internal/operators/min';
 export { multicast } from '../internal/operators/multicast';
 export { observeOn } from '../internal/operators/observeOn';
-export { onErrorResumeNext } from '../internal/operators/onErrorResumeNext';
+export { onErrorResumeNext } from '../internal/operators/onErrorResumeNextWith';


Suggested change (if you decide to have onErrorResumeNext.ts and onErrorResumeNextWith.ts files):

export { onErrorResumeNext } from '../internal/operators/onErrorResumeNext'; export { onErrorResumeNextWith } from '../internal/operators/onErrorResumeNextWith';

… from top level The `onErrorResumeNext` operator is deprecated due to a rename. The rename was done so we can move all operator exports to the top level `rxjs` export site. We were not currently exporting that operator. This commit also refactors to logic to be based on the creation function, which is more widely used

…artition

jakovljevic-mladen · 2022-09-27T07:09:49Z

src/internal/operators/onErrorResumeNextWith.ts

+/**
+ * @deprecated Renamed. Use {@link onErrorResumeNextWith} instead. Will be removed in v8.
+ */
+export const onErrorResumeNext = onErrorResumeNextWith;


It looks like other constants are having the same issue. E.g. flatMap:

So, I don't think this is something we can do about by moving to another file, which would be OK only for consistency reasons, nothing else.

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [rxjs](https://rxjs.dev) ([source](https://github.com/reactivex/rxjs)) | dependencies | minor | [`7.5.7` -> `7.8.0`](https://renovatebot.com/diffs/npm/rxjs/7.5.7/7.8.0) | --- ### Release Notes <details> <summary>reactivex/rxjs</summary> ### [`v7.8.0`](https://github.com/reactivex/rxjs/blob/HEAD/CHANGELOG.md#780-httpsgithubcomreactivexrxjscompare770780-2022-12-15) [Compare Source](ReactiveX/rxjs@7.7.0...7.8.0) ##### Features - **buffer:** `closingNotifier` now supports any `ObservableInput` ([#7073](ReactiveX/rxjs#7073)) ([61b877a](ReactiveX/rxjs@61b877a)) - **delayWhen:** `delayWhen`'s `delayDurationSelector` now supports any `ObservableInput` ([#7049](ReactiveX/rxjs#7049)) ([dfd95db](ReactiveX/rxjs@dfd95db)) - **sequenceEqual:** `compareTo` now supports any `ObservableInput` ([#7102](ReactiveX/rxjs#7102)) ([d501961](ReactiveX/rxjs@d501961)) - **share:** `ShareConfig` factory properties now supports any `ObservableInput` ([#7093](ReactiveX/rxjs#7093)) ([cc3995a](ReactiveX/rxjs@cc3995a)) - **skipUntil:** `notifier` now supports any `ObservableInput` ([#7091](ReactiveX/rxjs#7091)) ([60d6c40](ReactiveX/rxjs@60d6c40)) - **window:** `windowBoundaries` now supports any `ObservableInput` ([#7088](ReactiveX/rxjs#7088)) ([8c4347c](ReactiveX/rxjs@8c4347c)) ### [`v7.7.0`](https://github.com/reactivex/rxjs/blob/HEAD/CHANGELOG.md#770-httpsgithubcomreactivexrxjscompare760770-2022-12-15) [Compare Source](ReactiveX/rxjs@7.6.0...7.7.0) ##### Features - **distinct:** `flush` argument now supports any `ObservableInput` ([#7081](ReactiveX/rxjs#7081)) ([74c9ebd](ReactiveX/rxjs@74c9ebd)) - **repeatWhen:** `notifier` supports `ObservableInput` ([#7103](ReactiveX/rxjs#7103)) ([8f1b976](ReactiveX/rxjs@8f1b976)) - **retryWhen:** `notifier` now supports any `ObservableInput` ([#7105](ReactiveX/rxjs#7105)) ([794f806](ReactiveX/rxjs@794f806)) - **sample:** `notifier` now supports any `ObservableInput` ([#7104](ReactiveX/rxjs#7104)) ([b18c2eb](ReactiveX/rxjs@b18c2eb)) ### [`v7.6.0`](https://github.com/reactivex/rxjs/blob/HEAD/CHANGELOG.md#760-httpsgithubcomreactivexrxjscompare757760-2022-12-03) [Compare Source](ReactiveX/rxjs@7.5.7...7.6.0) ##### Bug Fixes - **schedulers:** no longer cause TypeScript build failures when Node types aren't included ([c1a07b7](ReactiveX/rxjs@c1a07b7)) - **types:** Improved subscribe and tap type overloads ([#6718](ReactiveX/rxjs#6718)) ([af1a9f4](ReactiveX/rxjs@af1a9f4)), closes [#6717](ReactiveX/rxjs#6717) ##### Features - **onErrorResumeNextWith:** renamed `onErrorResumeNext` and exported from the top level. (`onErrorResumeNext` operator is stil available, but deprecated) ([#6755](ReactiveX/rxjs#6755)) ([51e3b2c](ReactiveX/rxjs@51e3b2c)) #### [7.5.7](ReactiveX/rxjs@7.5.6...7.5.7) (2022-09-25) ##### Bug Fixes - **schedulers:** improve performance of animationFrameScheduler and asapScheduler ([#7059](ReactiveX/rxjs#7059)) ([c93aa60](ReactiveX/rxjs@c93aa60)), closes [#7017](ReactiveX/rxjs#7017), related to [#7018](ReactiveX/rxjs#7018) and [#6674](ReactiveX/rxjs#6674) ##### Performance Improvements - **animationFrames:** uses fewer Subscription instances ([#7060](ReactiveX/rxjs#7060)) ([2d57b38](ReactiveX/rxjs@2d57b38)), closes [#7018](ReactiveX/rxjs#7018) #### [7.5.6](ReactiveX/rxjs@7.5.5...7.5.6) (2022-07-11) ##### Bug Fixes - **share:** No longer results in a bad-state observable in an edge case where a synchronous source was shared and refCounted, and the result is subscribed to twice in a row synchronously. ([#7005](ReactiveX/rxjs#7005)) ([5d4c1d9](ReactiveX/rxjs@5d4c1d9)) - **share & connect:** `share` and `connect` no longer bundle scheduling code by default ([#6873](ReactiveX/rxjs#6873)) ([9948dc2](ReactiveX/rxjs@9948dc2)), closes [#6872](ReactiveX/rxjs#6872) - **exhaustAll:** Result will now complete properly when flattening all synchronous observables. ([#6911](ReactiveX/rxjs#6911)) ([3c1c6b8](ReactiveX/rxjs@3c1c6b8)), closes [#6910](ReactiveX/rxjs#6910) - **TypeScript:** Now compatible with TypeScript 4.6 type checks ([#6895](ReactiveX/rxjs#6895)) ([fce9aa1](ReactiveX/rxjs@fce9aa1)) #### [7.5.5](ReactiveX/rxjs@7.5.4...7.5.5) (2022-03-08) ##### Bug Fixes - **package:** add types to exports ([#6802](ReactiveX/rxjs#6802)) ([3750f75](ReactiveX/rxjs@3750f75)) - **package:** add `require` export condition ([#6821](ReactiveX/rxjs#6821)) ([c8955e4](ReactiveX/rxjs@c8955e4)) - **timeout:** no longer will timeout when receiving the first value synchronously ([#6865](ReactiveX/rxjs#6865)) ([2330c96](ReactiveX/rxjs@2330c96)), closes [#6862](ReactiveX/rxjs#6862) ##### Performance Improvements - Don't clone observers unless you have to ([#6842](ReactiveX/rxjs#6842)) ([3289d20](ReactiveX/rxjs@3289d20)) #### [7.5.4](ReactiveX/rxjs@7.5.3...7.5.4) (2022-02-09) ##### Performance Improvements - removed code that would `bind` functions passed with observers to `subscribe`. ([#6815](ReactiveX/rxjs#6815)) ([fb375a0](ReactiveX/rxjs@fb375a0)), closes [#6783](ReactiveX/rxjs#6783) #### [7.5.3](ReactiveX/rxjs@7.5.2...7.5.3) (2022-02-08) ##### Bug Fixes - **subscribe:** allow interop with Monio and other libraries that patch function bind ([0ab91eb](ReactiveX/rxjs@0ab91eb)), closes [#6783](ReactiveX/rxjs#6783) #### [7.5.2](ReactiveX/rxjs@7.5.1...7.5.2) (2022-01-11) ##### Bug Fixes - operators that ignore input values now use `unknown` rather than `any`, which should resolve issues with eslint no-unsafe-argument ([#6738](ReactiveX/rxjs#6738)) ([67cb317](ReactiveX/rxjs@67cb317)), closes [#6536](ReactiveX/rxjs#6536) - **ajax:** crossDomain flag deprecated and properly reported to consumers ([#6710](ReactiveX/rxjs#6710)) ([7fd0575](ReactiveX/rxjs@7fd0575)), closes [#6663](ReactiveX/rxjs#6663) #### [7.5.1](ReactiveX/rxjs@7.5.0...7.5.1) (2021-12-28) ##### Bug Fixes - export supporting interfaces from top-level `rxjs` site. ([#6733](ReactiveX/rxjs#6733)) ([299a1e1](ReactiveX/rxjs@299a1e1)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: cabr2-bot <[email protected]> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1668 Reviewed-by: Epsilon_02 <[email protected]> Co-authored-by: Calciumdibromid Bot <[email protected]> Co-committed-by: Calciumdibromid Bot <[email protected]>

benlesh requested review from cartant and kwonoj January 11, 2022 21:48

benlesh added 7.x Issues and PRs for version 7.x 8.x Issues and PRs for version 8.x labels Jan 11, 2022

jakovljevic-mladen reviewed Jan 14, 2022

View reviewed changes

benlesh mentioned this pull request Mar 9, 2022

Version 7 -> 8 Roadmap #6367

Open

40 tasks

ReactiveX deleted a comment from kbrilla Sep 25, 2022

benlesh added 2 commits September 25, 2022 14:09

docs: Update import information for onErrorResumeNext, fix info for p…

144107a

…artition

benlesh force-pushed the onErrorResumeNextWith branch from a803892 to 144107a Compare September 25, 2022 19:18

jakovljevic-mladen approved these changes Sep 27, 2022

View reviewed changes

benlesh merged commit 51e3b2c into ReactiveX:master Dec 3, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(onErrorResumeNextWith): renamed `onErrorResumeNext` and exported from the top level #6755

feat(onErrorResumeNextWith): renamed `onErrorResumeNext` and exported from the top level #6755

benlesh commented Jan 11, 2022

benlesh commented Jan 11, 2022

jakovljevic-mladen commented Jan 12, 2022

jakovljevic-mladen left a comment •

edited

Loading

jakovljevic-mladen Jan 14, 2022 •

edited

Loading

benlesh Sep 25, 2022

jakovljevic-mladen Sep 25, 2022

jakovljevic-mladen Sep 25, 2022

jakovljevic-mladen Sep 27, 2022

jakovljevic-mladen Jan 14, 2022 •

edited

Loading

jakovljevic-mladen Sep 27, 2022

feat(onErrorResumeNextWith): renamed onErrorResumeNext and exported from the top level #6755

feat(onErrorResumeNextWith): renamed onErrorResumeNext and exported from the top level #6755

Conversation

benlesh commented Jan 11, 2022

benlesh commented Jan 11, 2022

jakovljevic-mladen commented Jan 12, 2022

jakovljevic-mladen left a comment • edited Loading

Choose a reason for hiding this comment

jakovljevic-mladen Jan 14, 2022 • edited Loading

Choose a reason for hiding this comment

benlesh Sep 25, 2022

Choose a reason for hiding this comment

jakovljevic-mladen Sep 25, 2022

Choose a reason for hiding this comment

jakovljevic-mladen Sep 25, 2022

Choose a reason for hiding this comment

jakovljevic-mladen Sep 27, 2022

Choose a reason for hiding this comment

jakovljevic-mladen Jan 14, 2022 • edited Loading

Choose a reason for hiding this comment

jakovljevic-mladen Sep 27, 2022

Choose a reason for hiding this comment

feat(onErrorResumeNextWith): renamed `onErrorResumeNext` and exported from the top level #6755

feat(onErrorResumeNextWith): renamed `onErrorResumeNext` and exported from the top level #6755

jakovljevic-mladen left a comment •

edited

Loading

jakovljevic-mladen Jan 14, 2022 •

edited

Loading

jakovljevic-mladen Jan 14, 2022 •

edited

Loading