Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Support 'allowPartialChunks' in the HttpDecoderSpec #3452

Closed
reta opened this issue Oct 2, 2024 · 1 comment · Fixed by #3453
Closed

[Feature] Support 'allowPartialChunks' in the HttpDecoderSpec #3452

reta opened this issue Oct 2, 2024 · 1 comment · Fixed by #3453
Labels
type/enhancement A general enhancement
Milestone
1.1.23

Comments

@reta
Copy link
Contributor

reta commented Oct 2, 2024

Motivation

The Netty's HttpDecoderConfig exposes allowPartialChunks property which hints the HttpObjectDecoded if the chunk could be split into multiple when chunk exceeds the readable bytes. The HttpDecoderSpec sadly does not provide the way to configure it.

Desired solution

Support 'allowPartialChunks' in the HttpDecoderSpec so it could be used to create HttpDecoderConfig instances with respective property set.

Considered alternatives

N/A

Additional context

We right now are running into an issue when the complete chunk should be consumed but the partial ones are being produced instead.

@violetagg I am happy to submit the pull request if the feature makes sense to you, thank you
@reta reta added status/need-triage A new issue that still need to be evaluated as a whole type/enhancement A general enhancement labels Oct 2, 2024
@reta reta mentioned this issue Oct 2, 2024
Closed
@violetagg violetagg removed the status/need-triage A new issue that still need to be evaluated as a whole label Oct 3, 2024
@violetagg
Copy link
Member

@reta We love PRs :)
Please base it on 1.1.x branch.

@reta reta mentioned this issue Oct 3, 2024
Merged
@violetagg violetagg added this to the 1.1.23 milestone Oct 3, 2024
@reta reta mentioned this issue Oct 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement A general enhancement
Projects
None yet
Milestone
1.1.23
Development

Successfully merging a pull request may close this issue.

Support allowPartialChunks in the HttpDecoderSpec reta/reactor-netty
2 participants
@reta @violetagg