-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use \Throwable exclusively in rejection function docs #142
Use \Throwable exclusively in rejection function docs #142
Conversation
Follow-up for 505cf5e.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changeset looks reasonable to me, but just one question: Is is common knowledge that Throwable
is the base of Exception
or should we perhaps make this more explicit? It's my understanding most common use cases would likely reject a promise with a subclass of Exception
such as RuntimeException
(and family) and it might make sense to keep this as a search keyword in the documentation?
Good point, i will try to rework the docs 👍 . But we must make sure to not recommend |
I concur, adding |
@clue added a short paragraph about |
c1a75d8
to
a747ad4
Compare
a747ad4
to
6a45c24
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update, changes LGTM! 💯
🎉 ! |
Follow-up for #138.