Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make classes final #80

Merged
merged 1 commit into from
Jan 7, 2017
Merged

Make classes final #80

merged 1 commit into from
Jan 7, 2017

Conversation

jsor
Copy link
Member

@jsor jsor commented Jan 7, 2017

Make classes which must not be extended final.

@jsor jsor added this to the v3.0 milestone Jan 7, 2017
@jsor jsor requested review from WyriHaximus and clue January 7, 2017 15:57
WyriHaximus
WyriHaximus approved these changes Jan 7, 2017
View reviewed changes
Copy link
Member

@WyriHaximus WyriHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please 🎉

@jsor jsor merged commit 660a835 into master Jan 7, 2017
@jsor jsor deleted the final branch January 7, 2017 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WyriHaximus WyriHaximus WyriHaximus approved these changes

@clue clue clue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jsor @WyriHaximus @clue