Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failures on OSX #111

Closed
andig opened this issue Oct 9, 2017 · 3 comments · Fixed by #112
Closed

Test failures on OSX #111

andig opened this issue Oct 9, 2017 · 3 comments · Fixed by #112

Comments

@andig
Copy link
Contributor

andig commented Oct 9, 2017

~/htdocs/react-stream master
❯ phpunit
PHPUnit 5.5.4 by Sebastian Bergmann and contributors.

............SSS.SSS.SSS.SSS.SSS.SSS.SSSFSSS.SSS.SSS............  63 / 154 ( 40%)
............................................................... 126 / 154 ( 81%)
...........................S                                    154 / 154 (100%)

Time: 3.6 seconds, Memory: 69.23MB

There was 1 failure:

1) React\Tests\Stream\DuplexResourceStreamIntegrationTest::testReadsMultipleChunksFromProcessPipe with data set #0 (Closure Object (...), Closure Object (...))
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'abc'
+'-n a
+-n b
+-n c
+'

/Users/andig/Documents/htdocs/react-stream/tests/DuplexResourceStreamIntegrationTest.php:263

FAILURES!
Tests: 154, Assertions: 228, Failures: 1, Skipped: 31.
@cboden
Copy link
Member

cboden commented Oct 9, 2017

Can confirm same results on macOS 10.12.6 w/ PHP v5.6.30

@andig
Copy link
Contributor Author

andig commented Oct 9, 2017

I will add osx travis coverage once it has been merged in socket to reproduce the final setup.

@clue
Copy link
Member

clue commented Oct 9, 2017

The above test basically means that executing echo -n test will actually echo -n test for Mac OS X while the test assumes -n is interpreted as an option flag. Let me look into this :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants