Increase performance by raising default buffer sizes to 64 KiB #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seeing an increase from 50MB/s to 700MB/s on my laptop with xdebug and from 260MB/s to 2500MB/s on the same laptop without xdebug, both on PHP 7. Big work servers stay the same at 700MB/s though on PHP 5.6, no xdebug. 👍 from me. P.S. Like the commit message 😆 |
|
LGTM |
This was referenced Aug 21, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The readable and writable side now use the same buffer sizes in order to avoid pausing the readable side when piping to a writable stream.
Running the
examples/benchmark-throughput.phpscript, this change alone increases performance from ~100 MiB/s to ~1400 MiB/s on my (rather mediocre) test system, using PHP 7.0.8.A buffer size of 64 KiB is a reasonable compromise between memory usage and performance, and the total buffer sizes can still be neglected even with thousands of open streams.