RDContainer.mm/h are attached which are detached from the Readium SDK project. #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Readium SDK people.
I send a pull request for update SDKLauncher-ios.
This is to include unchanged RDContainer.mm/h files which are detached from the Readium SDK project.
The reason why those files are attached SDKLauncher-iOS rather than Readium SDK is:
The merge should be done together with disposal of the pull request of the Readium SDK.
Because only one disposal of either SDKLauncher-iOS or Readium SDK could make duplication or missing files problem.
And for the consistency of the Readium codes, in the future, we recommend all Launcher related files should locate at Launcher project instead of Readium SDK like Launcher-OSX case.