Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this project still actively maintained? #321

Closed
HppZ opened this issue Feb 21, 2020 · 13 comments
Closed

Is this project still actively maintained? #321

HppZ opened this issue Feb 21, 2020 · 13 comments

Comments

@HppZ
Copy link

HppZ commented Feb 21, 2020

I want to use this sdk in my windows 10 UWP project.

@danielweck
Copy link
Member

Hello, there have been prior efforts to create a Windows-compatible build configuration (Win32, WinRT, and also UWP), but as far as I know this hasn't been maintained for a long time.
I cannot remember exactly, but here are related Pull Requests:
#192
#124

Personally I have been maintaining the build configurations for Android and iOS, in this PR:
#317

@HppZ
Copy link
Author

HppZ commented Feb 21, 2020

Hi, Why not make it happen, Windows is great and UWP is great. There is no good epub reader on Windows, the legacy Edge was good, but it is not available since Windows 1909, so I want to create a epub app using Xaml, but I need a good epub parser, so I found readium-sdk, could you please please please support Windows platform?

@llemeurfr
Copy link
Contributor

There is no good epub reader on Windows

At EDRLab we're very actively developing Thorium Reader as a "good epub reader on Windows" + MacOS + Linux. We chose Electron to be cross-platform.

could you please please please support Windows platform?

Readium is a community, not a company. The c++ epub parser included in the Readium SDK works well, for several years. Making sure is compiles well and can be UWP wrapped for modern Windows build systems is in your hands. If you decide to do that, a gift to the community would be appreciated.

@danielweck
Copy link
Member

Hello again, this is an open-source project, so anybody is welcome to fork the codebase and propose feature extensions / improvements :)
That being said, I personally believe the effort required to bridge the C++ code with the UWP framework would be costly, and (in my opinion) not justified.
There is more active Readium development in platform-native code (e.g. Android-Kotlin, iOS-Swift), and as Laurent said in his comment above, there is also a cross-platform Electron-based implementation of the same Readium architecture.

@HppZ
Copy link
Author

HppZ commented Feb 21, 2020

Thanks for all your reply.

I tried Thorium Reader, and an error occured.
Uploading image.png…

@HppZ
Copy link
Author

HppZ commented Feb 21, 2020

image

@HppZ
Copy link
Author

HppZ commented Feb 21, 2020

is it trying to connect to internet?

@danielweck
Copy link
Member

This bug was fixed after version 1.1.1 was released, could you please try again with a more recent build from: https://github.com/readium/readium-desktop/releases/
Thank you!

@HppZ
Copy link
Author

HppZ commented Feb 21, 2020

current is v1.1.1

image

@danielweck
Copy link
Member

Yes, please try [latest-windows] continuous test build (prerelease)

@HppZ
Copy link
Author

HppZ commented Feb 21, 2020

oh works fine.

@llemeurfr
Copy link
Contributor

Note that this discussion about Thorium bugs has nothing to do in the readium-sdk area :-)

@llemeurfr
Copy link
Contributor

so, shall we close this issue now?

@HppZ HppZ closed this as completed Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants