Fix for uncompressed media playback issue in libzip #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a file is marked "uncompressed" inside a ZIP file, the current libzip code in the Readium SDK will take a different code path. Unfortunately, there is a small bug in that code path that results that, when dealing with an uncompressed ZIP entry, the code will lose track of its correct position in the file. This fix just adds some code so that it can keep track correctly of the position inside the uncompressed file, and that allows the playback of the uncompressed media to happen fine. Just a note: by "uncompressed" we mean uncompressed from the ZIP file point of view - evidently the media file, if it is a MPEG-4 file for example, will be highly compressed.
|
Related issue: #158 |
|
Addressed issue: #177 |
|
Should this PR now be closed? See: |
|
Resolved: #177 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had written the fix in this branch sometime ago. However, instead of taking this fix, I tried to update the libzip code in the Readium SDK to the latest version of that code, given that the libzip Open Source project is still alive and kicking. I discovered a problem, though: libzip evolved too much since we took it in the Readium SDK. The Readium SDK code uses some features that are no longer available in the current version of libzip: they have been replaced for more advanced versions, that would require a whole lot more work to make things work just the same. The problem, then, is that I do not have the time now for all the work that would be required to modify the Readium SDK so that it could use the latest version of the libzip code. On the other hand, we cannot simply leave this issue without a fix. So, I'm proposing that we merge my fix to libzip to develop, so that we unblock ourselves. At a later time, somebody that has the time for that can try again to take the latest libzip code.