fix: imports #1050
Merged
fix: imports #1050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kellyjosephprice
requested review from
rafegoldberg,
davinhazard and
trishaprile
davinhazard
reviewed
Jan 28, 2025
|
|
||
| render(<Component />); | ||
|
|
||
| expect(screen.getByText('TEST')).toBeInTheDocument(); |
There was a problem hiding this comment.
where is it defined that {user.test} returns 'TEST'?
There was a problem hiding this comment.
https://github.com/readmeio/markdown/blob/next/utils/user.ts
Hmm, I'm realizing now, that this doesn't totally match the old behavior of providing a dropdown though: https://github.com/readmeio/variable/blob/main/index.jsx#L116-L131
davinhazard
approved these changes
Jan 28, 2025
|
This PR was released!🚀 Changes included in v7.14.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Fixes user variables in the mdx-renderer.
The mdx-renderer passes in
{ imports: { React } }as they have to provide their own compiled version.lib/runwas not properly merging that with it's own imports, and that was causinguserto be undefined!🧬 QA & Testing