Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add html to hast #901

Merged
merged 1 commit into from
Jun 12, 2024
Merged

feat: add html to hast #901

merged 1 commit into from
Jun 12, 2024

Conversation

kellyjosephprice
Copy link
Collaborator

@kellyjosephprice kellyjosephprice commented Jun 7, 2024 •
edited
Loading

PR App RM-9820

🧰 Changes

Adds a htmlToHast function.

This will be used in indexing,

mdx -> rmdx.run(rmdx.compile(mdx)) ->
       react -> renderToSring(react) ->
       html -> htmlToHast(html) ->
       hast -> plain(hast) -> indexable plain text!

🧬 QA & Testing

@kellyjosephprice kellyjosephprice changed the base branch from next to beta June 7, 2024 22:29
@kellyjosephprice kellyjosephprice marked this pull request as ready for review June 7, 2024 22:30
rafegoldberg
rafegoldberg approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@rafegoldberg rafegoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@kellyjosephprice kellyjosephprice merged commit 6de3d89 into beta Jun 12, 2024
9 of 11 checks passed
@kellyjosephprice kellyjosephprice deleted the feat/add-html-to-hast branch June 12, 2024 18:49
rafegoldberg pushed a commit that referenced this pull request Jun 12, 2024
@semantic-release-bot
build(release): 🚀 v6.75.0-beta.54 🦉
dfc7c51 
## Version 6.75.0-beta.54

### ✨ New & Improved

* add html to hast ([#901](#901)) ([6de3d89](6de3d89))

### 🛠 Fixes & Updates

* cleanup ([e34ebf5](e34ebf5))

<!--SKIP CI-->
@rafegoldberg
Copy link
Contributor

This PR was released!

🚀 Changes included in v6.75.0-beta.54

@kellyjosephprice kellyjosephprice mentioned this pull request Jul 9, 2024
Closed
rafegoldberg pushed a commit that referenced this pull request Jan 8, 2025
@semantic-release-bot
build(release): 🚀 v7.11.0 🦉
23e7751 
## Version 7.11.0
### ✨ New & Improved

* add title props to plain ([#1036](#1036)) ([a3b7f50](a3b7f50))

### 🛠 Fixes & Updates

* **deps:** bump debug from 4.3.7 to 4.4.0 ([#1038](#1038)) ([a5a8061](a5a8061))
* **deps:** bump readmeio/rdme from 8 to 9 ([#1037](#1037)) ([3f403de](3f403de)), closes [/github.com/readmeio/rdme/blob/HEAD/#migrating-to-rdme10](https://github.com/readmeio//github.com/readmeio/rdme/blob/HEAD//issues/migrating-to-rdme10) [#1099](https://github.com/readmeio/markdown/issues/1099) [#1085](https://github.com/readmeio/markdown/issues/1085) [#1106](https://github.com/readmeio/markdown/issues/1106) [#1107](https://github.com/readmeio/markdown/issues/1107) [#1068](https://github.com/readmeio/markdown/issues/1068) [#962](#962) [#1067](https://github.com/readmeio/markdown/issues/1067) [github.com/readmeio/rdme/blob/d01d76fe3c2e4a98b4f5c415be03e589fbe3b56e/.releaserc.yml#L30](https://github.com/readmeio/github.com/readmeio/rdme/blob/d01d76fe3c2e4a98b4f5c415be03e589fbe3b56e/.releaserc.yml/issues/L30) [#1067](https://github.com/readmeio/markdown/issues/1067) [#1072](https://github.com/readmeio/markdown/issues/1072) [#1100](https://github.com/readmeio/markdown/issues/1100) [#1078](https://github.com/readmeio/markdown/issues/1078) [#1042](#1042) [#908](#908) [#901](#901) [#1073](https://github.com/readmeio/markdown/issues/1073) [#1080](https://github.com/readmeio/markdown/issues/1080) [#961](#961) [#963](#963) [#993](#993) [github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V20.md#2023-11-22-version-20100](https://github.com/readmeio/github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V20.md/issues/2023-11-22-version-20100) [#965](#965) [#1080](https://github.com/readmeio/markdown/issues/1080) [#1106](https://github.com/readmeio/markdown/issues/1106) [#1105](https://github.com/readmeio/markdown/issues/1105) [#1098](https://github.com/readmeio/markdown/issues/1098) [#1099](https://github.com/readmeio/markdown/issues/1099) [#1100](https://github.com/readmeio/markdown/issues/1100)
* dont treat escapes as flow ([#1040](#1040)) ([4692ece](4692ece))

<!--SKIP CI-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafegoldberg rafegoldberg rafegoldberg approved these changes

@Dashron Dashron Awaiting requested review from Dashron

@jennspencer jennspencer Awaiting requested review from jennspencer

@trishaprile trishaprile Awaiting requested review from trishaprile

Assignees
No one assigned
Labels
released on @beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kellyjosephprice @rafegoldberg