This repository has been archived by the owner on Oct 5, 2023. It is now read-only.
fix: stricter type #248
Merged
fix: stricter type #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erunion
approved these changes
Jan 31, 2023
| @@ -29,7 +29,7 @@ export default class OASNormalize { | |||
|
|
|||
| opts: Options; | |||
|
|
|||
| type: boolean | string; | |||
There was a problem hiding this comment.
huh, wonder why i did this as boolean
There was a problem hiding this comment.
technically it returns false:
oas-normalize/src/lib/utils.ts
Line 48 in 057cf54
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
As part of the work I'm doing in readmeio/rdme#735 I'm using the
typevalue that's used in theOASNormalizeclass. This PR gives thetypevalue a stricter TS type.🧬 QA & Testing
I
npm link'd it tordmeand confirmed the stricter type is surfaced properly: