Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preverse scrollbar gap when op #450

Merged
merged 3 commits into from
Sep 27, 2019

Conversation

namjul
Copy link
Contributor

@namjul namjul commented Sep 27, 2019

Closes #449

Before:
dialog-before

After:
dialog-after

The header is fixed thereof ignores the padding-right on body from reserveScrollBarGap
Did not checked why the right sidebar moves.

Anyway this just adds a padding-right of scroll-bar-width.

@namjul namjul requested a review from diegohaz as a code owner September 27, 2019 08:39
@ariakit-bot
Copy link

ariakit-bot commented Sep 27, 2019

Deploy preview for reakit ready!

Built with commit 718a096

https://deploy-preview-450--reakit.netlify.com

@diegohaz
Copy link
Member

Hi @namjul! Could you please run yarn test -u to update snapshots?

@namjul
Copy link
Contributor Author

namjul commented Sep 27, 2019

It does not change any snapshots. The tests run successfully locally. The failed build seams to come from the gatsby build..

@diegohaz
Copy link
Member

Your branch was several commits outdated. I guess that's why it was working locally. Updated it and it's working now! Thanks! 😊

@codecov-io
Copy link

codecov-io commented Sep 27, 2019

Codecov Report

Merging #450 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #450   +/-   ##
======================================
  Coverage    95.3%   95.3%           
======================================
  Files          94      94           
  Lines        1427    1427           
  Branches      446     446           
======================================
  Hits         1360    1360           
  Misses         67      67
Impacted Files Coverage Δ
.../reakit/src/Dialog/__utils/usePreventBodyScroll.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36e0d63...718a096. Read the comment docs.

@diegohaz diegohaz merged commit d84fd10 into ariakit:master Sep 27, 2019
@ariakit-bot
Copy link

Thanks a lot for contributing!

Based on our community guidelines, every person who has a PR of any kind merged is offered an invitation to the Reakit organization.

Should you accept, you'll get write access to the main repository and a fancy Reakit logo on your GitHub profile. You'll be able to label and close issues, create new branches etc. Make sure to read our contribution and community guidelines, which explains all of this in more detail.

If you have any questions, let me know!

@namjul namjul deleted the feat/dialog-preserve-scrollbar-gap branch September 28, 2019 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove open Dialog flicker
4 participants