-
-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preverse scrollbar gap when op #450
Preverse scrollbar gap when op #450
Conversation
Deploy preview for reakit ready! Built with commit 718a096 |
Hi @namjul! Could you please run |
It does not change any snapshots. The tests run successfully locally. The failed build seams to come from the gatsby build.. |
Your branch was several commits outdated. I guess that's why it was working locally. Updated it and it's working now! Thanks! 😊 |
Codecov Report
@@ Coverage Diff @@
## master #450 +/- ##
======================================
Coverage 95.3% 95.3%
======================================
Files 94 94
Lines 1427 1427
Branches 446 446
======================================
Hits 1360 1360
Misses 67 67
Continue to review full report at Codecov.
|
Thanks a lot for contributing! Based on our community guidelines, every person who has a PR of any kind merged is offered an invitation to the Reakit organization. Should you accept, you'll get write access to the main repository and a fancy Reakit logo on your GitHub profile. You'll be able to label and close issues, create new branches etc. Make sure to read our contribution and community guidelines, which explains all of this in more detail. If you have any questions, let me know! |
Closes #449
Before:
![dialog-before](https://user-images.githubusercontent.com/328836/65755138-cd356400-e112-11e9-85a1-add0fc19167f.gif)
After:
![dialog-after](https://user-images.githubusercontent.com/328836/65755137-cc9ccd80-e112-11e9-9e76-ca222a4adbba.gif)
The header is fixed thereof ignores the padding-right on body from
reserveScrollBarGap
Did not checked why the right sidebar moves.
Anyway this just adds a padding-right of scroll-bar-width.