From 55e8be64b05b5fa8d315d2c9dbd7f27181551c87 Mon Sep 17 00:00:00 2001 From: Michael Barker Date: Fri, 30 Aug 2024 06:57:42 +1200 Subject: [PATCH] [Java] Comments and cleanup. --- aeron-client/src/main/java/io/aeron/Aeron.java | 2 ++ .../src/main/java/io/aeron/PublicationErrorFrameHandler.java | 1 + .../src/main/java/io/aeron/command/ControlProtocolEvents.java | 1 + .../java/io/aeron/command/PublicationErrorFrameFlyweight.java | 1 + .../src/main/java/io/aeron/protocol/ErrorFlyweight.java | 1 + .../src/main/java/io/aeron/driver/PublicationImage.java | 4 ---- 6 files changed, 6 insertions(+), 4 deletions(-) diff --git a/aeron-client/src/main/java/io/aeron/Aeron.java b/aeron-client/src/main/java/io/aeron/Aeron.java index 1fe22080c22..2320f41a879 100644 --- a/aeron-client/src/main/java/io/aeron/Aeron.java +++ b/aeron-client/src/main/java/io/aeron/Aeron.java @@ -1736,6 +1736,7 @@ public ThreadFactory threadFactory() * * @param publicationErrorFrameHandler to be called back when an error frame is received. * @return this for a fluent API. + * @since 1.47.0 */ public Context publicationErrorFrameHandler( final PublicationErrorFrameHandler publicationErrorFrameHandler) @@ -1749,6 +1750,7 @@ public Context publicationErrorFrameHandler( * this client. * * @return the {@link PublicationErrorFrameHandler} to call back on to. + * @since 1.47.0 */ public PublicationErrorFrameHandler publicationErrorFrameHandler() { diff --git a/aeron-client/src/main/java/io/aeron/PublicationErrorFrameHandler.java b/aeron-client/src/main/java/io/aeron/PublicationErrorFrameHandler.java index 163f637d9e1..31fe6a425e3 100644 --- a/aeron-client/src/main/java/io/aeron/PublicationErrorFrameHandler.java +++ b/aeron-client/src/main/java/io/aeron/PublicationErrorFrameHandler.java @@ -19,6 +19,7 @@ /** * Interface for handling various error frame messages for publications. + * @since 1.47.0 */ public interface PublicationErrorFrameHandler { diff --git a/aeron-client/src/main/java/io/aeron/command/ControlProtocolEvents.java b/aeron-client/src/main/java/io/aeron/command/ControlProtocolEvents.java index f06b06a01e5..616309887d3 100644 --- a/aeron-client/src/main/java/io/aeron/command/ControlProtocolEvents.java +++ b/aeron-client/src/main/java/io/aeron/command/ControlProtocolEvents.java @@ -171,6 +171,7 @@ public class ControlProtocolEvents /** * Inform clients of error frame received by publication + * @since 1.47.0 */ public static final int ON_PUBLICATION_ERROR = 0x0F0C; } diff --git a/aeron-client/src/main/java/io/aeron/command/PublicationErrorFrameFlyweight.java b/aeron-client/src/main/java/io/aeron/command/PublicationErrorFrameFlyweight.java index dfe0a2244a9..d72c187978a 100644 --- a/aeron-client/src/main/java/io/aeron/command/PublicationErrorFrameFlyweight.java +++ b/aeron-client/src/main/java/io/aeron/command/PublicationErrorFrameFlyweight.java @@ -62,6 +62,7 @@ * ... | * +---------------------------------------------------------------+ * + * @since 1.47.0 */ public class PublicationErrorFrameFlyweight { diff --git a/aeron-client/src/main/java/io/aeron/protocol/ErrorFlyweight.java b/aeron-client/src/main/java/io/aeron/protocol/ErrorFlyweight.java index 40ef4c50e15..46dc9eae2a7 100644 --- a/aeron-client/src/main/java/io/aeron/protocol/ErrorFlyweight.java +++ b/aeron-client/src/main/java/io/aeron/protocol/ErrorFlyweight.java @@ -50,6 +50,7 @@ * ... | * +---------------------------------------------------------------+ * + * @since 1.47.0 */ public class ErrorFlyweight extends HeaderFlyweight { diff --git a/aeron-driver/src/main/java/io/aeron/driver/PublicationImage.java b/aeron-driver/src/main/java/io/aeron/driver/PublicationImage.java index 6a71b39f95c..7b674ab31ba 100644 --- a/aeron-driver/src/main/java/io/aeron/driver/PublicationImage.java +++ b/aeron-driver/src/main/java/io/aeron/driver/PublicationImage.java @@ -592,10 +592,6 @@ int insertPacket( if (null != rejectionReason) { - if (isEndOfStream) - { - System.out.println("Invalidated end of stream"); - } return 0; }