Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy-Settings not working since version 1.1.1 #226

Closed
GR-C opened this issue Jul 8, 2024 · 3 comments
Closed

Proxy-Settings not working since version 1.1.1 #226

GR-C opened this issue Jul 8, 2024 · 3 comments

Comments

@GR-C
Copy link

GR-C commented Jul 8, 2024

What happened?

Hello,

After updating from version 1.0.0 to version 2.1.0, I noticed that the proxy settings no longer take effect. I checked the code and identified the cause in the modification of the send_request_to_server method (f643313) due to Issue 189.

At first glance, it appears that the proxy address requires a scheme. That works, but it’s only by coincidence. The call proxy_uri.get_auth(proxy_userinfo, proxy_host, proxy_port); provides the hostname (for proxy_host) inadvertently by specifying the scheme. However, if you look into the proxy_uri variable, you will see that the hostname is stored in the m_auth property and not under m_path, where I believe it belongs.

Regards
Giuseppe

Repro steps

I specify the proxy settings like in the code below.

auto appConfig = realm::App::configuration();
appConfig.app_id = "myAppId";

// other configuration steps here...

realm::proxy_config proxyConfig;
proxyConfig.address  = address = "proxy.example.com";
proxyConfig.port = 8888; 

appConfig.proxy_configuration = proxyConfig;

auto app = realm::App(appConfig);
auto user = app.login(apiKey).get(); // Login throws an app_error exception saying "Invalid argument" 

Version

2.1.0

Installation method

Manual compile

What Atlas Services are you using?

Atlas Device Sync

Compiler

MSBuild

OS and version

Windows 11

Code snippets

No response

Stacktrace of the exception/crash you're getting

No response

Relevant log output

No response

Copy link

sync-by-unito bot commented Jul 8, 2024

➤ PM Bot commented:

Jira ticket: RCPP-83

@leemaguire
Copy link
Contributor

Hi @GR-C, This will be addressed in #216

@nirinchev
Copy link
Member

Closing since #216 was merged.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants