From 45050cd8ebb8d2f6347247f81f055b02dcbc1925 Mon Sep 17 00:00:00 2001 From: Nikola Irinchev Date: Wed, 30 Jun 2021 00:52:05 +0300 Subject: [PATCH] PR review comments --- CHANGELOG.md | 5 +++-- Realm/Realm/Handles/AppHandle.cs | 6 ++---- wrappers/realm-core | 2 +- 3 files changed, 6 insertions(+), 7 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 20ba466932..22641ff164 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,8 +1,9 @@ ## vNext (TBD) ### Fixed -* \[Unity] Fixed an issue where failing to weave an assembly due to modeling errors, would only show an error in the logs once and then fail opening a Realm with `No RealmObjects. Has linker stripped them?`. Now, the weaving errors will show up on every code change/weave attempt and the runtime error will explicitly suggest manually re-running the weaver. (Issue [#2310](https://github.com/realm/realm-dotnet/issues/2310)) -* \[Unity] Fixed an issue that would cause the app to hang on exit when using Sync. (PR [#2467](https://github.com/realm/realm-dotnet/pull/2467)) +* \[Unity\] Fixed an issue where failing to weave an assembly due to modeling errors, would only show an error in the logs once and then fail opening a Realm with `No RealmObjects. Has linker stripped them?`. Now, the weaving errors will show up on every code change/weave attempt and the runtime error will explicitly suggest manually re-running the weaver. (Issue [#2310](https://github.com/realm/realm-dotnet/issues/2310)) +* \[Unity\] Fixed an issue that would cause the app to hang on exit when using Sync. (PR [#2467](https://github.com/realm/realm-dotnet/pull/2467)) +* \[Unity\] Fixed an issue that would cause the Unity editor on macOS to hang after assembly reload if the app uses Sync. (Issue [#2482](https://github.com/realm/realm-dotnet/issues/2482)) ### Enhancements * None diff --git a/Realm/Realm/Handles/AppHandle.cs b/Realm/Realm/Handles/AppHandle.cs index 6f00d11e57..97da779702 100644 --- a/Realm/Realm/Handles/AppHandle.cs +++ b/Realm/Realm/Handles/AppHandle.cs @@ -219,10 +219,8 @@ public static void ForceCloseHandles() { foreach (var weakHandle in _appHandles) { - if (weakHandle.Target is AppHandle handle) - { - handle?.Close(); - } + var appHandle = (AppHandle)weakHandle.Target; + appHandle?.Close(); } _appHandles.Clear(); diff --git a/wrappers/realm-core b/wrappers/realm-core index d85d071cc2..9c1f2a563b 160000 --- a/wrappers/realm-core +++ b/wrappers/realm-core @@ -1 +1 @@ -Subproject commit d85d071cc25b6f64fabbbebbaaae20f367ef64ae +Subproject commit 9c1f2a563bfb9bdbf46723efc0974bd072fb9793