Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't deselect nodes in multiModifier mode #283

Open
faseidl opened this issue Oct 9, 2024 · 0 comments
Open

Can't deselect nodes in multiModifier mode #283

faseidl opened this issue Oct 9, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@faseidl
Copy link

faseidl commented Oct 9, 2024

Describe the bug

When using the multiModifier selection type, once the modifier key has been pressed (and detected by the onKeyDown handler), there is no way to deselect nodes. It appears the problem is that there is no corresponding onKeyUp handler to detect when the modifier key is released.

Steps to Reproduce the Bug or Issue

  1. Create a graph using mulitModifier selection mode
  2. Press the modifier key and select a couple of nodes.
  3. Release the modifier key.
  4. Notice that the graph continues to behave as if the modifier key were pressed.
  5. Click the canvas to clear the selection.
  6. Notice that when clicking nodes the graph behaves (correctly) as if the modifier key were not pressed.

Expected behavior

After step 4 (in the step to reproduce the bug above), I expect to be able to deselect a selected node by clicking on it, or select a single node by clicking on a deselected node.

Screenshots or Videos

No response

Platform

  • Reagraph Version: 4.19.3
  • OS: macOS
  • Browser: Chrome, Safari
  • NodeJS version: v22.4.1

Your Example Website or App

No response

Additional context

No response

@amcdnl amcdnl added the bug Something isn't working label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants