Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests in the appropriate extra dependencies. #1516

Closed
laserprec opened this issue Sep 1, 2021 · 0 comments · Fixed by #1517
Closed

Run tests in the appropriate extra dependencies. #1516

laserprec opened this issue Sep 1, 2021 · 0 comments · Fixed by #1517
Assignees
Labels
enhancement New feature or request

Comments

@laserprec
Copy link
Contributor

Description

Our recommender package has several extra dependencies to address the different compute environments: recommender[spark,gpu,example,dev]. We should run our tests against the specific extra dependency so we can ensure users of the library would have minimum problems installing these extra dependencies.

Expected behavior with the suggested feature

For example:

  • A user pip install recommenders[gpu, examples] should be able to run recommender utilities tested by pytest -m "gpu and notebooks and not spark

Other Comments

@laserprec laserprec added enhancement New feature or request build labels Sep 1, 2021
@laserprec laserprec self-assigned this Sep 1, 2021
@laserprec laserprec linked a pull request Sep 1, 2021 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant