-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Replace the FastAI notebook by a cartesian product with PyTorch and remove the FastAI dependency #2186
Comments
IDEA: I'm sure ChatGPT can translate the notebook to PyTorch |
@miguelgfierro I am unclear with the requirements. Do we just want to replace the Cartesian product or we want to completely replace fast-ai with the PyTorch? |
@rohan-rajput-ai the idea is to remove all the code related to FastAI, and replace it with the underlying PyTorch. The output of this work needs to be a remade notebook, the removal of https://github.com/recommenders-team/recommenders/blob/main/recommenders/models/fastai/fastai_utils.py and the removal of the fastai dependency https://github.com/recommenders-team/recommenders/blob/main/setup.py#L54. If you need to create any function, feel free to create a |
hi @rohan-rajput-ai is there any advance on this? |
I guess to remove the fast ai dependency, we need to use meshgrid method and stacking arrays. if this is the case then I can do this @miguelgfierro |
I think @rohan-rajput-ai is working on this project. Maybe you can work together? @srivani21 are you in the slack channel of Recommenders? if so, ping me. Maybe it would be quicker if we started a chat. |
Please share me the link of slack channel @miguelgfierro |
Description
We had some issues with the FastAI dependency #2182. And realised that the fastai notebook is just a fancy wrapper on PyTorch cartesian product between user and item embeddings.
https://github.com/recommenders-team/recommenders/blob/main/examples/00_quick_start/fastai_movielens.ipynb
Expected behavior with the suggested feature
We want replace the FastAI notebook with a PyTorch version
Willingness to contribute
Other Comments
Related to #1713
The text was updated successfully, but these errors were encountered: