Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RenameForeachValueVariableToMatchExprVariableRector bug $RectorPrefix202501 #8962

Closed
mletoullec opened this issue Jan 6, 2025 · 3 comments
Closed
Labels

Comments

@mletoullec
Copy link

mletoullec commented Jan 6, 2025

I have a bug for some time :

https://getrector.com/demo/b23f7fd6-41c9-41df-9baf-752f6bf121cd

I would like to display $movie instead of $row and not $RectorPrefix202501movie

@mletoullec mletoullec added the bug label Jan 6, 2025
@samsonasik
Copy link
Member

The issue seems on scoped vendor/doctrine/inflector

$replacements = ['/\\W/' => ' ', '/([A-Z]+)([A-Z][a-z])/' => 'RectorPrefix202501\\1_\\2', '/([a-z\\d])([A-Z])/' => 'RectorPrefix202501\\1_\\2', '/[^A-Z^a-z^0-9^\\/]+/' => '-'];

I will look into patch the scoper script.

@samsonasik
Copy link
Member

It tooks 3 times try, it should be resolved at

please try latest "rector/rector": "dev-main"

@mletoullec
Copy link
Author

I just tested on the dev-main branch, it's good, it works correctly. Many thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants