Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default for ENVOY_ADMIN_API #12

Open
greatvovan opened this issue Nov 8, 2019 · 2 comments
Open

Default for ENVOY_ADMIN_API #12

greatvovan opened this issue Nov 8, 2019 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@greatvovan
Copy link

I suggest defaulting ENVOY_ADMIN_API to http://localhost:15000 to satisfy the most common case.

@linjmeyer linjmeyer added enhancement New feature or request good first issue Good for newcomers labels Dec 2, 2019
@linjmeyer
Copy link

I think it's a good suggestion. Right now this env variable being set is what enables Scuttle, that is necessary to ensure things like docker run work for local development outside of a Kubernetes/Istio cluster. Setting this to the default is okay, we just need to add a new environment variable like ENVOY_ADMIN_POLLING=TRUE/FALSE or similar.

@greatvovan
Copy link
Author

greatvovan commented Dec 7, 2019

I see your point, indeed, it is a case, too. But I would prefer to override the default value of ENVOY_ADMIN_API with "" for local runs rather than add it for production. Alternatively we can have SCUTTLE_ENABLED variable defaulting to true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants