From 73306e54a548fe329cca6d2ad098957df6ff24bf Mon Sep 17 00:00:00 2001 From: Yuxuan 'fishy' Wang Date: Wed, 8 May 2024 11:02:32 -0700 Subject: [PATCH] thriftbp: Deprecate ServerConfig.ReportPayloadSizeMetricsSampleRate We marked DefaultProcessorMiddlewaresArgs.ReportPayloadSizeMetricsSampleRate as deprecated in a previous PR, but forgot to also mark ServerConfig.ReportPayloadSizeMetricsSampleRate as deprecated. --- thriftbp/server.go | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/thriftbp/server.go b/thriftbp/server.go index 246e0a39e..61be13450 100644 --- a/thriftbp/server.go +++ b/thriftbp/server.go @@ -56,6 +56,9 @@ type ServerConfig struct { // // Report the payload size metrics with this sample rate. // If not set none of the requests will be sampled. + // + // Deprecated: Server side payload size reporting is always 100% enabled when + // using NewBaseplateServer. ReportPayloadSizeMetricsSampleRate float64 // Optional, used by NewBaseplateServer and NewServer. @@ -139,9 +142,8 @@ func NewBaseplateServer( ) (baseplate.Server, error) { middlewares := BaseplateDefaultProcessorMiddlewares( DefaultProcessorMiddlewaresArgs{ - EdgeContextImpl: bp.EdgeContextImpl(), - ErrorSpanSuppressor: cfg.ErrorSpanSuppressor, - ReportPayloadSizeMetricsSampleRate: cfg.ReportPayloadSizeMetricsSampleRate, + EdgeContextImpl: bp.EdgeContextImpl(), + ErrorSpanSuppressor: cfg.ErrorSpanSuppressor, }, ) middlewares = append(middlewares, cfg.Middlewares...)