Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extension doesn't show one's not logged into the OpenShift cluster #17

Open
fbricon opened this issue Apr 21, 2022 · 1 comment · May be fixed by #65
Open

Extension doesn't show one's not logged into the OpenShift cluster #17

fbricon opened this issue Apr 21, 2022 · 1 comment · May be fixed by #65
Assignees
@dgolovin
Labels
enhancement New feature or request

Comments

@fbricon
Copy link
Collaborator

fbricon commented Apr 21, 2022

If I run oc logout in a terminal, when I open the extension, the current context shows as if I was logged in. Subsequent image deployment fails because anonymous user has no rights.

There should be a way to visually show a user is actually logged in or not.
@dgolovin
Copy link
Collaborator

This is something that can happen at any time anywhere and nothing we can do about it.
Simplest way is to check login status before executing command and if user is not logged in show a warning and request to login.
Even this approach can fail sometimes, because session can expire even in the middle of 'oc new-application' execution.

@dgolovin dgolovin added the enhancement New feature or request label Apr 27, 2022
@dgolovin dgolovin self-assigned this Apr 28, 2022
@fbricon fbricon linked a pull request Jul 7, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgolovin dgolovin

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check if user is logged into cluster before deploying fbricon/openshift-dd-ext
2 participants
@fbricon @dgolovin