Syntax highlighting is not working with comment

[Munodi]

Normally a comment would be grey-greened out but I've discovered an instance where it is not.

Environment

• Operating System: Windows 10 64 bit
• JDK version: 9
• Visual Studio Code version: 1.17.1
• Java extension version: 0.12.0

Steps To Reproduce

1. Create a class and add the code below to it.
2. See that the comment is not highlighted correctly like it is in GitHub.

private JPanel plottingSurface = new JPanel() /* {
        @Override
        public Dimension getPreferredSize() {
            return new Dimension(400, 300);
        }
        @Override
        protected void paintComponent(Graphics g) {
            super.paintComponent(g);
        }
    }*/;

Current Result

not syntax-highlighted

Expected Result

Comment between first and last line coloured correctly

Additional Informations

Interestingly adding a semicolon before the comment colours the comment as expected

[fbricon]

Syntax highlighting is provided by the Textmate bundle embedded in vscode. Usually that kind of syntax highlighting problem is caused by a bug in the upstream Textmate bundle, but here, the issue can not be reproduced in Textmate, so this looks like a bug in vscode itself. Can you please open a report in https://github.com/Microsoft/vscode/issues?

cc @aeschli

[snjeza]

I have converted the latest Textmate - https://github.com/textmate/java.tmbundle. It works fine.

java.tmLanguage.json

[snjeza]

[fbricon]

@snjeza Please open a PR to vscode-java and link it here

[snjeza]

[fbricon]

With the vscode 1.19.3 (probably earlier versions too), highlighting is better, but there are still some issues with comments in the middle of a variable declaration:

[Eskibear]

Version: 1.41.0-insider
Commit: fe03510f9e9fb269ca35da0ea600dd95279fa2b7
Date: 2019-11-18T05:25:58.947Z
Electron: 6.1.4
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Darwin x64 17.7.0

Looks good now.

[Vigilans]

There are still some issues with comment.

It is owing to the massive usage of look around assertions in java's textmate grammar.

[fbricon]

This is partially fixed with the new semantic highlighting support in vscode-java 0.61.0. Requires "java.semanticHighlighting.enabled": true in settings.json. Without semantic highlighting, the Textmate grammar is still broken.