-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code snippet should be working before LS done resolving Maven dependencies #684
Comments
@akaroml For vscode java, there are two types of code snipeets: Client snippet such as main and server snippet. For client snippet, it will always work no matter the language server is ready or not. public_method should be client snippet and should be ready before LS ready. |
As for now the client snippet will always work and the server snippet will update to the list once server is ready. This issue can be closed. @testforstephen @rgrunber |
The client side snippets don't always work for me. For a Maven project (eg. spring-petclinic), the snippets resolve initially, but as soon as the project import begins (standard LS as show in the screenshot), the completion no longer responds until after the build is completed, which can take a bit of time. Seems like this is still an issue. |
Yes I can also repro it. Put a breakpoint at
|
I'm not sure if something has changed since trying out this PR, but the behaviour is a bit different for me now. This is without the PR attached.
|
@rgrunber The PR #2240 should solve the issue you mentioned here. If I remember correctly, we only have
|
Maven dependencies take lots of time to resolve.
![image](https://user-images.githubusercontent.com/16755094/47280661-124f3d00-d60a-11e8-9c19-5c5a99bc5d2c.png)
At that moment, LS is not responding to user key strokes. But some of the features like code snippet can acutally work. The idea is to enable some language servers before the project is completely loaded. Code snippet can be a good start because it require less project context. For example, the
public_method
does not require project context but only the surrounding class.The text was updated successfully, but these errors were encountered: