Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial support for renaming #71

Closed
3 of 5 tasks
fbricon opened this issue Oct 18, 2016 · 4 comments
Closed
3 of 5 tasks

Add initial support for renaming #71

fbricon opened this issue Oct 18, 2016 · 4 comments

Comments

@fbricon
Copy link
Collaborator

fbricon commented Oct 18, 2016

We should add some refactoring options for renaming

  • parameters
  • fields. Getters/Setters are a special case
  • methods
  • classes (although my understanding is vs code/language server protocol doesn't support file renaming)
  • packages
@gorkem
Copy link
Contributor

gorkem commented Oct 19, 2016

see also eclipse-jdtls/eclipse.jdt.ls#43

@yaohaizh
Copy link
Collaborator

@fbricon @gorkem Could you guys help assign this one to me? I would like to work on this one.

@fbricon fbricon marked this as a duplicate of #261 Jul 25, 2017
@fbricon fbricon added this to the End August 2017 milestone Aug 28, 2017
@fbricon fbricon changed the title Add support for renaming Add initial support for renaming Aug 29, 2017
@fbricon
Copy link
Collaborator Author

fbricon commented Aug 29, 2017

Initial support for renaming as landed. Because the language server protocol doesn't support renaming files, only renaming symbols is available now.

Renaming a class, will change the class name but won't rename the file, you'll have to fix the class/filename discrepancy manually.

Kudos to @yaohaizh for the contribution

@fbricon fbricon closed this as completed Aug 29, 2017
@andreysaksonov
Copy link

andreysaksonov commented May 10, 2018

@fbricon I observed that rename symbol for class also break imports in other files (instead of fqdn it places simple class name). Is it LSP issue or vscode-java?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants