User feedback regarding performance

[akaroml]

A user left some comments for Java Extension Pack and it's regarding language server performance.

There are two aspects to this problem:

1. The long lag for language server to load bigger projects (~8500 files in this case)
2. Progress update was not effective and the user gets the "stops responding" impression

While @yaohaizh is pushing for 1, @testforstephen could you please help revisit 2?

Here's the source of the comments:
https://marketplace.visualstudio.com/items?itemName=vscjava.vscode-java-pack&ssr=false#review-details

[kelvinwop]

I feel like adding a short sleep every once in awhile would greatly help the "vscode has stopped responding" part. I mean the computation part is inevitable, but stopping once in awhile to check for user input would do wonders for responsiveness. Not sure how easy or hard that would be to implement though (or depending on design of code whether or not that would even help lol, just an idea).

[kelvinwop]

some pics for effect

[yaohaizh]

@kelvinwop Could you attach your log information here. See how to get log information: https://github.com/redhat-developer/vscode-java/wiki/Troubleshooting#enable-logging

[kelvinwop]

Aha, you're in luck! It just froze:
https://paste.ofcode.org/FzBfetrNzCFfPqyktjT3eK

[yaohaizh]

@kelvinwop Could you help disable other java extension(Debugger for Java, Maven for Java, Java Dependency Viewer, Java Test Runner), leave only the Language Support for Java(TM) by redhat, and try it to see whether the perf issue hits?

[snjeza]

Related issues - eclipse-jdtls/eclipse.jdt.ls#824, microsoft/vscode-java-pack#81

[kelvinwop]

Will do,

Extra info: when I get this notification:

there is no lag ever but all the "find references/control click trace/etc" break beyond all hell (eg. send you to the wrong file, interpret stuff wrong, send you to the wrong methods, etc etc)

[akaroml]

Related issues - eclipse/eclipse.jdt.ls#824, Microsoft/vscode-java-pack#81

Here's more on microsoft/vscode-java-pack#81. It turns out to be a vscode issue. We observed lots of such issues recently and got no luck in all the investigations. And after some time, other extension authors started to receive similar issues, and then we started to suspect it was a vscode issue. @Eskibear has more info and will update that issue. It will be closed soon.

[kelvinwop]

Some more info: after disabling the other extensions, I got the Classpath is incomplete error on every file. After enabling it again, the lag went away and the Find By References broke. In any case, I've moved to android studio for the android sdk support. Thanks!

[yaohaizh]

@kelvinwop So you open Android project in VSCode? If this is the case, VSCode Java has not support Android yet. See the related issue: #396

[kelvinwop]

Yeah I realized that pretty quick, but funnily, vscode's file search/function tracing is better than intelliJ/android studio, despite having pages upon pages of errors. Anyways I finished most of the tracing work so I'm now moving between IDEs depending on what I'm doing

[apupier]

in 2019:

It will be closed soon.

@akashshinde @Eskibear any update on this issue?