Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatter broken when use socks5 proxy #1005

Open
Ksc0721 opened this issue May 31, 2024 · 2 comments
Open

Formatter broken when use socks5 proxy #1005

Ksc0721 opened this issue May 31, 2024 · 2 comments

Comments

@Ksc0721
Copy link

Ksc0721 commented May 31, 2024

According to Visual Code's http.proxy settings https://github.com/microsoft/vscode/blob/main/src/vs/platform/request/common/request.ts#L143

It could be "socks5://10.1.2.3:7777", and doesn't match vscode-xml's HOST_AND_PORT_EXTRACTOR
https://github.com/redhat-developer/vscode-xml/blob/main/src/settings/proxySettings.ts#L155

In a word, it will produce a Cannot read properties of null (reading '1') exception, and the language client will not started.

@angelozerr
Copy link
Contributor

Is there any chance to have a PR?

@ivanbarsukov
Copy link

Unfortunately, not only formatting, but the entire extension does not work if socks5 proxy is enabled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants