From d0834221f27baeb48804553002ec698592f2ebbb Mon Sep 17 00:00:00 2001 From: Arya Emami Date: Sun, 7 Apr 2024 06:19:17 -0500 Subject: [PATCH] Remove `no-resolution` flag when running `are-the-types-wrong` during CI - `@arethetypeswrong/cli` now has an `--exclude-entrypoints` flag which we can use to exclude the `alternate-renderers` entrypoint from the check since it will fail under the `Node10` module resolution as `Node10` looks at actual files on disk and we don't have a file named `alternate-renderers`. --- .github/workflows/test.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 6dcf20fa9..3b6b807e1 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -93,10 +93,8 @@ jobs: path: . # Note: We currently expect "FalseCJS" failures for Node16 + `moduleResolution: "node16", - # and the `/alternateRenderers" entry point will not resolve under Node10. - # Skipping these is dangerous, but we'll leave it for now. - name: Run are-the-types-wrong - run: npx @arethetypeswrong/cli ./package.tgz --format table --ignore-rules false-cjs no-resolution + run: npx @arethetypeswrong/cli ./package.tgz --format table --ignore-rules false-cjs --exclude-entrypoints alternate-renderers test-published-artifact: name: Test Published Artifact ${{ matrix.example }}