From 51f3a04b139bbe4a26337e0c0546e070e363b1b8 Mon Sep 17 00:00:00 2001
From: Arya Emami <aryaemami59@yahoo.com>
Date: Sat, 10 Feb 2024 22:08:34 -0600
Subject: [PATCH 1/2] Check if `maxSize` is less than or equal to 1

---
 src/lruMemoize.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/lruMemoize.ts b/src/lruMemoize.ts
index ddc3036a4..b2d0e7775 100644
--- a/src/lruMemoize.ts
+++ b/src/lruMemoize.ts
@@ -205,7 +205,7 @@ export function lruMemoize<Func extends AnyFunction>(
   let resultsCount = 0
 
   const cache =
-    maxSize === 1
+    maxSize <= 1
       ? createSingletonCache(comparator)
       : createLruCache(maxSize, comparator)
 

From d6379b1e3a6a1c1a671926e4ef619041d1b53467 Mon Sep 17 00:00:00 2001
From: Arya Emami <aryaemami59@yahoo.com>
Date: Sat, 10 Feb 2024 22:09:20 -0600
Subject: [PATCH 2/2] Add unit tests for when `maxSize` is set to a number that
 is less than 1

---
 test/lruMemoize.test.ts | 40 +++++++++++++++++++++++++++++++++++++++-
 1 file changed, 39 insertions(+), 1 deletion(-)

diff --git a/test/lruMemoize.test.ts b/test/lruMemoize.test.ts
index 5a6583959..b7c5bd5dd 100644
--- a/test/lruMemoize.test.ts
+++ b/test/lruMemoize.test.ts
@@ -1,7 +1,8 @@
 // TODO: Add test for React Redux connect function
 
 import { createSelectorCreator, lruMemoize } from 'reselect'
-import { vi } from 'vitest'
+import type { RootState } from './testUtils'
+import { localTest, toggleCompleted } from './testUtils'
 
 const createSelector = createSelectorCreator({
   memoize: lruMemoize,
@@ -414,4 +415,41 @@ describe(lruMemoize, () => {
     // @ts-expect-error
     expect(selector.resultFunc.clearCache).toBeUndefined()
   })
+
+  localTest(
+    'maxSize should default to 1 when set to a number that is less than 1',
+    ({ state, store }) => {
+      const createSelectorLru = createSelectorCreator({
+        memoize: lruMemoize,
+        argsMemoize: lruMemoize,
+        memoizeOptions: { maxSize: 0 },
+        argsMemoizeOptions: { maxSize: 0 }
+      }).withTypes<RootState>()
+
+      const selectTodoIds = createSelectorLru([state => state.todos], todos =>
+        todos.map(({ id }) => id)
+      )
+
+      expect(selectTodoIds(store.getState())).toBe(
+        selectTodoIds(store.getState())
+      )
+
+      expect(selectTodoIds.recomputations()).toBe(1)
+
+      store.dispatch(toggleCompleted(0))
+
+      expect(selectTodoIds(store.getState())).toBe(
+        selectTodoIds(store.getState())
+      )
+
+      expect(selectTodoIds.recomputations()).toBe(2)
+
+      const selectTodoIdsLru = lruMemoize(
+        (state: RootState) => state.todos.map(({ id }) => id),
+        { maxSize: -2 }
+      )
+
+      expect(selectTodoIdsLru(state)).toBe(selectTodoIdsLru(state))
+    }
+  )
 })