Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get error after scaffold post #5380

Closed
PeterChen1997 opened this issue May 2, 2022 · 7 comments
Closed

get error after scaffold post #5380

PeterChen1997 opened this issue May 2, 2022 · 7 comments
Assignees
Labels
bug/confirmed We have confirmed this is a bug

Comments

@PeterChen1997
Copy link
Contributor

PeterChen1997 commented May 2, 2022

After upgrade 1.2.0, and doing scaffold Post. The graphql server yell error like this

api | API listening on http://localhost:8911/
api | GraphQL endpoint at /graphql
api | 10:17:41 🌲 Server listening at http://[::]:8911
api | 10:17:41 🌲 incoming request POST xxx /graphql
api | 10:17:41 🚨 this.splice is not a function 
api | TypeError: this.splice is not a function
api |     at HeadersList.append (/Users/peterchen/code_hub/redwood-app/node_modules/cross-undici-fetch/dist/patch-headers-list.js:44:16)
api |     at Headers.append (/Users/peterchen/code_hub/redwood-app/node_modules/undici/lib/fetch/headers.js:215:31)
api |     at buildRequestObject (/Users/peterchen/code_hub/redwood-app/node_modules/@redwoodjs/graphql-server/dist/functions/graphql.js:262:24)
api |     at handlerFn (/Users/peterchen/code_hub/redwood-app/node_modules/@redwoodjs/graphql-server/dist/functions/graphql.js:324:23)
api |     at execFn (/Users/peterchen/code_hub/redwood-app/node_modules/@redwoodjs/graphql-server/dist/functions/graphql.js:364:22)
api |     at AsyncLocalStorage.run (node:async_hooks:322:14)
api |     at /Users/peterchen/code_hub/redwood-app/node_modules/@redwoodjs/graphql-server/dist/functions/graphql.js:373:58
api |     at requestHandler (/Users/peterchen/code_hub/redwood-app/node_modules/@redwoodjs/api-server/dist/requestHandlers/awsLambdaFastify.js:116:26)
api |     at Object.lambdaRequestHandler (/Users/peterchen/code_hub/redwood-app/node_modules/@redwoodjs/api-server/dist/plugins/withFunctions.js:115:47)
api |     at preHandlerCallback (/Users/peterchen/code_hub/redwood-app/node_modules/fastify/lib/handleRequest.js:126:28) 
api | {

I think the problem is the new version of graphql-tools

I tried in ts and js mode, get the same problem

@jtoar jtoar added this to Triage May 2, 2022
@jtoar jtoar moved this to Needs triage in Triage May 2, 2022
@PeterChen1997 PeterChen1997 changed the title Typescript - get error after scaffold post get error after scaffold post May 2, 2022
@PeterChen1997
Copy link
Contributor Author

maybe relate to this #5262

@jtoar jtoar added the bug/confirmed We have confirmed this is a bug label May 2, 2022
@jtoar jtoar assigned jtoar and unassigned callingmedic911 May 2, 2022
@jtoar
Copy link
Contributor

jtoar commented May 2, 2022

@PeterChen1997 thanks for reporting! I was able to reproduce this and it's failing in our CI as well. I'll escalate this.

@PeterChen1997
Copy link
Contributor Author

Thx! Waiting for the good news

@jtoar
Copy link
Contributor

jtoar commented May 2, 2022

@PeterChen1997 We've got a fix for it here: #5378. I'll see about releasing a patch or maybe we'll just wait till the minor Tuesday, but since this is breaking, a patch feels more appropriate. But it's in canary if you want to try it out now and confirm:

yarn rw upgrade -t canary

@jherdman
Copy link

jherdman commented May 2, 2022

I can confirm that this works.

@jtoar
Copy link
Contributor

jtoar commented May 2, 2022

We just released a patch for this: https://github.com/redwoodjs/redwood/releases/tag/v1.2.1. Please upgrade and let us know!

yarn rw upgrade

@jtoar jtoar closed this as completed May 2, 2022
Repository owner moved this from Needs triage to Done in Triage May 2, 2022
@mikepage
Copy link

After upgrading to version 1.4.0 this error returns.
#5526

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/confirmed We have confirmed this is a bug
Projects
No open projects
Status: Done
Development

No branches or pull requests

5 participants