Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug?]: redwood doesn't recognize storybook config files with ts, tsx extensions. #9118

Closed
1 task done
bnn1 opened this issue Sep 1, 2023 · 5 comments · Fixed by #9309
Closed
1 task done

[Bug?]: redwood doesn't recognize storybook config files with ts, tsx extensions. #9118

bnn1 opened this issue Sep 1, 2023 · 5 comments · Fixed by #9309
Labels
bug/confirmed We have confirmed this is a bug

Comments

@bnn1
Copy link
Contributor

bnn1 commented Sep 1, 2023 •
edited by jtoar
Loading

What's not working?

After I rename storybook config files, for example storybook.preview.js to storybook.preview.ts, storybook reverts back to default preview configuration.

How do we reproduce the bug?

  1. init a ui library, i.e. yarn rw setup ui mantine
  2. rename storybook.preview.js to storybook.preview.tsx
  3. run storybook to see that providers/css files imported in preview file have no effect

What's your environment? (If it applies)

No response

Are you interested in working on this?

  • I'm interested in working on this
@bnn1 bnn1 added the bug/needs-info More information is needed for reproduction label Sep 1, 2023
@bnn1
Copy link
Contributor Author

bnn1 commented Sep 1, 2023

I'd want to work on this issue. I already am 😅

@jtoar
Copy link
Contributor

jtoar commented Sep 12, 2023

Hey @bnn1, thanks for reporting this and sorry for the delay! Have you started on a PR? I'd be happy to review.

@jtoar jtoar added bug/confirmed We have confirmed this is a bug and removed bug/needs-info More information is needed for reproduction labels Sep 12, 2023
@bnn1
Copy link
Contributor Author

bnn1 commented Oct 5, 2023

Hi @jtoar. I've been working on the issue but no PR yet. I'll keep you updated.

@bnn1 bnn1 mentioned this issue Oct 17, 2023
Merged
@beardo01
Copy link

beardo01 commented Nov 8, 2023

Adding support for this PR. Would like to get this working as Storybook is currently not working with Mantine UI for me.

@bnn1
Copy link
Contributor Author

bnn1 commented Nov 8, 2023

@beardo01 it's most likely related to another issue: #9316
That issue is already being worked on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug/confirmed We have confirmed this is a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add TS support for storybook preview tsx config extension bnn1/redwood
3 participants
@beardo01 @jtoar @bnn1