Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md to use pkgs.system instead of system #89

Merged
merged 1 commit into from
May 14, 2024
Merged

Update README.md to use pkgs.system instead of system #89

merged 1 commit into from
May 14, 2024

Conversation

no-mood
Copy link
Contributor

@no-mood no-mood commented May 13, 2024 •
edited
Loading

This doesn't require to pass system too, and generally seems a better practice.

redyf
redyf approved these changes May 14, 2024
View reviewed changes
Copy link
Owner

@redyf redyf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm so used to

  home.packages = with pkgs; [
    inputs.Neve.packages.${system}.default
  ];

that I forget some people might have trouble for not having "with pkgs" in their configs. Your approach does make more sense indeed, thanks for the contribution!

@redyf redyf merged commit e106a67 into redyf:main May 14, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@redyf redyf redyf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@no-mood @redyf