Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 2.7 not actually supported #4

Open
henryiii opened this issue Oct 6, 2021 · 1 comment
Open

Python 2.7 not actually supported #4

henryiii opened this issue Oct 6, 2021 · 1 comment

Comments

@henryiii
Copy link

henryiii commented Oct 6, 2021

Using this is broken from Python 2; see https://github.com/tomerfiliba/plumbum/pull/561/checks . You are using the old egg-based setup_requires, which is deprecated and doesn't work correctly and is pulling a Python 3 only version of setuptoools-scm. The best fix would be to add universal wheels for releases and also add a pyproject.toml file.

After fixing this you can drop Python 2 support by changing the python_requires - but that should always be the first thing to change, not the last, since pip will get old versions of the package on old versions of the language, that's fine.

@henryiii
Copy link
Author

henryiii commented Oct 6, 2021

I recommend looking over https://scikit-hep.org/developer or https://packaging.python.org/tutorials/packaging-projects/. Also, you should add this to your setup.cfg:

[bdist_wheel]
universal = 1

(And then remove it when you drop Python 2 support)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant