Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vitest does not catch invalid cases #59

Closed
scarf005 opened this issue Aug 26, 2024 · 1 comment
Closed

vitest does not catch invalid cases #59

scarf005 opened this issue Aug 26, 2024 · 1 comment

Comments

@scarf005
Copy link
Contributor

after #58, vitest will not catch invalid cases such as:

image

this is likely due to using deprecated API with incompatible function.

image
@scarf005 scarf005 mentioned this issue Aug 26, 2024
Closed
@fregante
Copy link
Member

Indeed I merged the PR too early. I fixed it in 7c05f2c

@fregante fregante closed this as not planned Won't fix, can't repro, duplicate, stale Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: catch invalid cases scarf005/shorten-repo-url
2 participants
@fregante @scarf005