Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] i18n notification message #3328

Closed
omeraplak opened this issue Jan 2, 2023 Discussed in #3325 · 3 comments · Fixed by #3436
Closed

[BUG] i18n notification message #3328

omeraplak opened this issue Jan 2, 2023 Discussed in #3325 · 3 comments · Fixed by #3436
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@omeraplak
Copy link
Member

Discussed in #3325

Originally posted by EugeneKostin December 30, 2022
Hi everyone,
I use default i18n namespace instead "common" and find untranslated notifications. In the refine-core src files, the useList hook notification uses a message with a common namespace when other hooks use the default. Is this an issue or am I missing something?

useList

...
message: translate(
    "common:notifications.error",
    { statusCode: err.statusCode },
    `Error (status code: ${err.statusCode})`,
),

useOne

...
message: translate(
    "notifications.error",
    { statusCode: err.statusCode },
    `Error (status code: ${err.statusCode})`,
),

Thanks for your help!

@omeraplak omeraplak added bug Something isn't working good first issue Good for newcomers labels Jan 3, 2023
@aliemir aliemir changed the title bug: i18n notification message [BUG] i18n notification message Jan 3, 2023
@5evki
Copy link
Contributor

5evki commented Jan 18, 2023

Hi @omeraplak,
Could you please assign me it?

@5evki
Copy link
Contributor

5evki commented Jan 20, 2023

Hey @omeraplak @aliemir,
I changed useList hook but i couldn't test it.
How can i test it?

@omeraplak
Copy link
Member Author

Hey @sevkioruc ,
Congrats! You can follow the contribution docs

https://refine.dev/docs/contributing/#running-in-development-mode

@omeraplak omeraplak linked a pull request Jan 21, 2023 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants