Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specs are broken due to Loofah whitelist #168

Closed
bricesanchez opened this issue Apr 6, 2016 · 5 comments
Closed

Specs are broken due to Loofah whitelist #168

bricesanchez opened this issue Apr 6, 2016 · 5 comments

Comments

@bricesanchez
Copy link
Member

Since my previous changes in the def wrap_content_in_tag :
https://github.com/refinery/refinerycms/blob/8d2778944572162be6eef8811c17be28a2cb374f/pages/app/presenters/refinery/pages/section_presenter.rb#L66-L70

Loofah strip placeholders in inputs.
@anitagraham
Copy link
Contributor

anitagraham commented Apr 6, 2016 •
edited by parndt
Loading

Is it Loofah?

I think I was loosing placeholders a couple of weeks ago, but didn¹t get to
follow it up.
At this point I would also suspect wymeditor.
(I suspect everyone)

@bricesanchez
Copy link
Member Author

It is Loofah. i think i will provide a PR with our own whitelist config, no more Loofah strange whitelist and deps.

@anitagraham
Copy link
Contributor

anitagraham commented Apr 6, 2016 •
edited by parndt
Loading

I have done a version of that, but not written tests (or tested it).

@bricesanchez
Copy link
Member Author

Nice, could you provide a PR ?

Let me know if i could help you :)

@bricesanchez
Copy link
Member Author

refinery/refinerycms#3164

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@anitagraham @bricesanchez