Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session extras in session listings are shown as numbers instead of strings #3404

Open
vkarak opened this issue Feb 26, 2025 · 0 comments
Open
Assignees
Labels
bug reporting Issues related to reporting and processing the test results
Milestone

Comments

@vkarak
Copy link
Contributor

vkarak commented Feb 26, 2025

When you pass a session extra that looks like a number, e.g. --session-extras x=12.30, ReFrame will show it as a number when listing the information of that session, although it has correctly stored it as a string.

Steps to reproduce

  1. Enable results storage
export RFM_ENABLE_RESULTS_STORAGE=y
  1. Run with --session-extras
reframe -c unittests/resources/checks/frontend_checks.py -n ^PerformanceFailureCheck -r --session-extras x=12.30,y=12.31
  1. View session listing
./bin/reframe --list-stored-sessions=<uuid>
┍━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┯━━━━━━━━━━━━━━━━━━━━━━┯━━━━━━━━━━━━━━━━━━━━━━┯━━━━━━━━━━━━┯━━━━━━━━━━━━━┯━━━━━━┯━━━━━━━┑
│ UUID                                 │ Start time           │ End time             │   Num runs │   Num cases │    x │     y │
┝━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┿━━━━━━━━━━━━━━━━━━━━━━┿━━━━━━━━━━━━━━━━━━━━━━┿━━━━━━━━━━━━┿━━━━━━━━━━━━━┿━━━━━━┿━━━━━━━┥
│ 8d470a9a-505d-490f-a749-ae30aff0cd1f │ 20250226T152854+0100 │ 20250226T152856+0100 │          1 │           1 │ 12.3 │ 12.31 │
┕━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┷━━━━━━━━━━━━━━━━━━━━━━┷━━━━━━━━━━━━━━━━━━━━━━┷━━━━━━━━━━━━┷━━━━━━━━━━━━━┷━━━━━━┷━━━━━━━┙

Note that x's value is listed as 12.3 instead of 12.30.

  1. Queries with string comparison though work as expected:
reframe --list-stored-sessions='?x=="12.30"'
┍━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┯━━━━━━━━━━━━━━━━━━━━━━┯━━━━━━━━━━━━━━━━━━━━━━┯━━━━━━━━━━━━┯━━━━━━━━━━━━━┯━━━━━━┯━━━━━━━┑
│ UUID                                 │ Start time           │ End time             │   Num runs │   Num cases │    x │     y │
┝━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┿━━━━━━━━━━━━━━━━━━━━━━┿━━━━━━━━━━━━━━━━━━━━━━┿━━━━━━━━━━━━┿━━━━━━━━━━━━━┿━━━━━━┿━━━━━━━┥
│ 8d470a9a-505d-490f-a749-ae30aff0cd1f │ 20250226T152854+0100 │ 20250226T152856+0100 │          1 │           1 │ 12.3 │ 12.31 │
┕━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┷━━━━━━━━━━━━━━━━━━━━━━┷━━━━━━━━━━━━━━━━━━━━━━┷━━━━━━━━━━━━┷━━━━━━━━━━━━━┷━━━━━━┷━━━━━━━┙

I think this is due to the default behaviour of tabulate that interprets table cells as numbers if they seem so.

@vkarak vkarak added bug reporting Issues related to reporting and processing the test results labels Feb 26, 2025
@vkarak vkarak added this to the ReFrame 4.8 milestone Feb 26, 2025
@vkarak vkarak self-assigned this Feb 26, 2025
@vkarak vkarak moved this to Todo in ReFrame Backlog Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug reporting Issues related to reporting and processing the test results
Projects
Status: Todo
Development

No branches or pull requests

1 participant