[refactor] Move builtins in a separate module file and improve make_test()
#2470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @vkarak, Thank you for updating! Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide Comment last updated at 2022-03-15 19:16:20 UTC |
vkarak
changed the title
make_test make_test()
added 2 commits
March 12, 2022 22:25
Codecov Report
@@ Coverage Diff @@
## master #2470 +/- ##
==========================================
+ Coverage 85.69% 85.70% +0.01%
==========================================
Files 56 57 +1
Lines 10534 10544 +10
==========================================
+ Hits 9027 9037 +10
Misses 1507 1507
Continue to review full report at Codecov.
|
|
@jenkins-cscs retry daint |
ekouts
approved these changes
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves all the builtins in the module
reframe.core.builtins. This is to allow their use with themake_test()utility function that defines tests dynamically. Builtins that were manipulating the directly the namespace of the class were refactored so that they don't need to do it. There is one exception, which is also the only builtin that didn't move to the new module: thebind()builtin. This builtin needs to bind a free function to the test class and therefore needs to manipulate the test class namespace. Unit tests are also added to testmake_test()with builtins. Finally, this PR moves all the documentation of the builtins in the source code avoiding duplication we had previously. The overall documentation for builtins is also slightly refactored.This PR is a prerequisite for #2458.
Fixes #2427.