Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Move CSCS tests and configuration out of this repo #2521

Merged
merged 10 commits into from
May 30, 2022

Conversation

vkarak
Copy link
Contributor

@vkarak vkarak commented May 24, 2022

The CSCS tests and the CSCS site-specific configuration have been moved to https://github.com/eth-cscs/cscs-reframe-tests.

There are still a couple of subtasks that need to be addressed before we merge this PR (see #2511 for more details).

Addresses #2511.

@codecov-commenter
Copy link

codecov-commenter commented May 25, 2022

Codecov Report

Merging #2521 (e1226b6) into master (7bd820b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2521   +/-   ##
=======================================
  Coverage   85.81%   85.81%           
=======================================
  Files          58       58           
  Lines       10800    10800           
=======================================
  Hits         9268     9268           
  Misses       1532     1532           
Impacted Files Coverage Δ
reframe/frontend/cli.py 71.02% <ø> (ø)
reframe/utility/osext.py 84.42% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bd820b...e1226b6. Read the comment docs.

Copy link
Contributor

@victorusu victorusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@ekouts ekouts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is config/cscs-ci.py on the repo left on purpose?

@vkarak
Copy link
Contributor Author

vkarak commented May 27, 2022

Is config/cscs-ci.py on the repo left on purpose?

Yes, because it's needed for the CSCS CI that tests the scheduler backends.

Copy link
Contributor

@ekouts ekouts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not necessary for this PR but since I saw that you changed the links to reframe-hpc, I think we also need to change the repo to reframe-hpc in the following files:

  • .pep8speaks.yml
  • CONTRIBUTING.md
  • setup.cfg
  • ci-scripts/deploy.sh
  • docs/conf.py
  • hpctestlib/microbenchmarks/gpu/gpu_burn.py
  • reframe/frontend/cli.py
  • reframe/schemas/config.json
  • reframe/schemas/runreport.json
  • reframe/utility/osext.py
  • unittests/test_config.py
  • unittests/test_utility.py

There are links to the contributing guidelines, to old issues etc..

@vkarak
Copy link
Contributor Author

vkarak commented May 27, 2022

@ekouts That's a valid observation. I will fix those links.

@vkarak vkarak merged commit bda0519 into reframe-hpc:master May 30, 2022
@vkarak vkarak deleted the ci/move-cscs-tests branch May 30, 2022 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants