Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Reset poll rate every time a test finishes the compilation or run phase #2534

Merged
merged 4 commits into from
Jun 10, 2022

Conversation

ekouts
Copy link
Contributor

@ekouts ekouts commented Jun 8, 2022

One other thing we have talked about and would make sense to do in this PR is to expose SLEEP_MIN, SLEEP_MAX and SLEEP_INC_RATE in the configuration. It would be better to do it by partition but it would require more changes so maybe it's better to open an issue and do it in the next sprint. What do you think @vkarak ?

Fixes #2531.

@ekouts ekouts added this to the ReFrame Sprint 22.05.2 milestone Jun 8, 2022
@ekouts ekouts requested a review from vkarak June 8, 2022 15:59
@ekouts ekouts self-assigned this Jun 8, 2022
@ekouts ekouts changed the title [bugfix] Reset poll rate every time a job finishes the compilation/run phase [bugfix] Reset poll rate every time a job finishes the compilation or run phase Jun 8, 2022
@ekouts ekouts changed the title [bugfix] Reset poll rate every time a job finishes the compilation or run phase [bugfix] Reset poll rate every time a test finishes the compilation or run phase Jun 8, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2022

Codecov Report

Merging #2534 (1971fdf) into master (e2d2406) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 1971fdf differs from pull request most recent head 0a38f66. Consider uploading reports for the commit 0a38f66 to get more accurate results

@@            Coverage Diff             @@
##           master    #2534      +/-   ##
==========================================
- Coverage   85.81%   85.80%   -0.01%     
==========================================
  Files          58       58              
  Lines       10800    10794       -6     
==========================================
- Hits         9268     9262       -6     
  Misses       1532     1532              
Impacted Files Coverage Δ
reframe/frontend/executors/policies.py 92.28% <100.00%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2d2406...0a38f66. Read the comment docs.

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still just a couple of minor changes.

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm now!

@vkarak
Copy link
Contributor

vkarak commented Jun 9, 2022

I tested also with the example in #2531 and it seems to work correctly now.

@ekouts
Copy link
Contributor Author

ekouts commented Jun 10, 2022

@jenkins-cscs retry all

@vkarak vkarak merged commit 1d85917 into reframe-hpc:master Jun 10, 2022
@ekouts ekouts deleted the bugfix/max_poll_rate branch June 10, 2022 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test execution time increases over time
3 participants