-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bugfix] Reset poll rate every time a test finishes the compilation or run phase #2534
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2534 +/- ##
==========================================
- Coverage 85.81% 85.80% -0.01%
==========================================
Files 58 58
Lines 10800 10794 -6
==========================================
- Hits 9268 9262 -6
Misses 1532 1532
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still just a couple of minor changes.
…bugfix/max_poll_rate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm now!
I tested also with the example in #2531 and it seems to work correctly now. |
@jenkins-cscs retry all |
One other thing we have talked about and would make sense to do in this PR is to expose
SLEEP_MIN
,SLEEP_MAX
andSLEEP_INC_RATE
in the configuration. It would be better to do it by partition but it would require more changes so maybe it's better to open an issue and do it in the next sprint. What do you think @vkarak ?Fixes #2531.