Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent reference to content hash in data module #1006

Closed
4 tasks
Tracked by #818
ryanchristo opened this issue Apr 11, 2022 · 0 comments · Fixed by #1014
Closed
4 tasks
Tracked by #818

Consistent reference to content hash in data module #1006

ryanchristo opened this issue Apr 11, 2022 · 0 comments · Fixed by #1014
Assignees
Labels
Scope: x/data Issues that update the x/data module Type: Refactor A code change that neither fixes a bug nor adds a feature

Comments

@ryanchristo
Copy link
Member

ryanchristo commented Apr 11, 2022

Summary

When anchoring and attesting to data, the messages require Hash and Hashes as an input. When registering data to a resolver, the message requires Data. Each field represents one or more content hashes. A content hash also includes a Hash field. We should use consistent and more descriptive field names.

Problem Definition

Inconsistent use of field names in the data module when referring to a content hash.

Proposal

Update hash to content_hash, hashes to content_hashes, and data to content_hashes.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@ryanchristo ryanchristo added Status: Proposed Scope: x/data Issues that update the x/data module labels Apr 11, 2022
@ryanchristo ryanchristo added this to the v4.0 - Llangorse Upgrade milestone Apr 12, 2022
@ryanchristo ryanchristo self-assigned this Apr 12, 2022
@ryanchristo ryanchristo added the Type: Refactor A code change that neither fixes a bug nor adds a feature label Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: x/data Issues that update the x/data module Type: Refactor A code change that neither fixes a bug nor adds a feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant