-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit tests for gRPC endpoints and CLI commands #1041
Comments
I agree integration tests should mostly be focused on the server level using I guess we could unit test CLI/gRPC with mocks? I would note that one of my goals in the Cosmos SDK this year is to deprecate manually written CLI and gRPC query methods. Ideally all of that would be auto-generated by reflection on |
Also relevant to cosmos/cosmos-sdk#12696 |
Summary
We are currently using the integration test suite for gRPC endpoints and CLI commands. This is redundant if we are also writing integration tests for the server implementation. This has also proven difficult to maintain and introduces nuances when checking the length of returned items from queries. Integration tests might not be the best route for gRPC and CLI commands but rather used only with the server implementation methods.
Problem Definition
The current client integration tests are redundant of the integration tests for the server implementation. How to write integration tests is not clear and the client integration tests are difficult to maintain and do not allow us to properly check the length of returned values.
Proposal
Update the client integration tests to unit tests, removing the use of the integration test suite.
For Admin Use
The text was updated successfully, but these errors were encountered: