Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BuyDirect corrupting supply #1067

Closed
4 tasks
Tracked by #818
technicallyty opened this issue Apr 28, 2022 · 0 comments · Fixed by #1069
Closed
4 tasks
Tracked by #818

BuyDirect corrupting supply #1067

technicallyty opened this issue Apr 28, 2022 · 0 comments · Fixed by #1069
Assignees
@technicallyty
Labels
Scope: x/ecocredit Issues that update the x/ecocredit module Type: Bug Something isn't working
Milestone
v4.0 - Llangorse ...

Comments

@technicallyty
Copy link
Contributor

Summary of Bug

buy direct is corrupting the supply. this was stale logic leftover from when supply had an escrowed field. supply should only be updated in marketplace transactions when credits are retired upon purchase.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@technicallyty technicallyty

Labels
Scope: x/ecocredit Issues that update the x/ecocredit module Type: Bug Something isn't working
Projects
None yet
Milestone
v4.0 - Llangorse Upgrade
Development

Successfully merging a pull request may close this issue.

fix(ecocredit/marketplace): correctly set supply during BuyDirect regen-network/regen-ledger
1 participant
@technicallyty